Jac Goudsmit

Sorry for the mess in the formatting. I don't use SourceForge often...

Suspicious code handling DH_Check output value in PSSLDiffieHellman::Construct

Hi Alex, Yes, I've been using the current head revision of the "jacmaster" branch in my forked tree (534b8fd288edcd8ab5de90bf63dd19940d8e2d3f) at my work, except for the Boost builds because we don't use Boost. ===Jac

The changes haven't been merged; the project hasn't received any maintenance since July 2017. Alexander Perepelkin and I had a discussion about another merge request that I entered, but it got really quiet even though the project is being downloaded a few hundred times per week, so people are obviously interested in it. Maybe you should download my fork at https://sourceforge.net/u/userid-2012122/log4cpp/ ? (Use the "jacmaster" branch)

The changes haven't been merged; the project hasn't received any maintenance since July 2017. Alexander Perepelkin and I had a discussion about another merge request that I entered, but it got really quiet even though the project is being downloaded a few hundred times per week, so people are obviously interested in it. Maybe you should download my fork at https://sourceforge.net/u/userid-2012122/log4cpp/ ?

Hi Alex, I just changed the code so that the member variables of the NTEventLogAppender class are not changed after construction. That means some things that were possible before this latest change (19cf8a969762599a198e0f276238d4b86977ffc9) like changing the DLL location on the fly, aren't possible anymore (as you requested), but I made it so that they can still be accomplished by creating a subclass. Thanks for considering! ===Jac

I'm sorry that it's taking me a while to get back on this; I've been very busy with work and other projects. I hope to fix the code in my repo later this week, then I'll update this discussion. Thanks! ===Jac

You reasonably introduced new constructor so the dllLocation can be specified explicitly. After location of dll is specified for the process, it is hardly possible that the same process will call reopen(const std::string &sourceName, const std::string &dllLocation) and change any of parameters. Therefore dllLocation is preferably to become constant field of the class: If I understand you correctly you want to store the DLL location at construction time, and then not allow the client code to change...