Menu

#231 shoppingcart.py: add REMOVE feature

Freevo 1.x series
closed
nobody
Plugins (215)
5
2007-10-24
2007-10-04
No

When I'm view images in freevo I use shoppingcart to remove some images. But now present only AddItemToCart feature for add image image filename into cart.

In my patch I add into AddItemToCart condition: if image filename present in cart - remove it from cart, else - add item to the cart.

Discussion

  • Valerii Koval

    Valerii Koval - 2007-10-04
     
  • Duncan Webb

    Duncan Webb - 2007-10-04
    • milestone: --> Freevo 1.x series
    • status: open --> pending
     
  • Duncan Webb

    Duncan Webb - 2007-10-04

    Logged In: YES
    user_id=104395
    Originator: NO

    Hi Valera

    I don't think that I will add this patch because it is a bit odd to select add to cart and it deletes it from the cart.

    A better change would be to change the menu so that when an item is in the cart it says delete from card and the add option is not available.

    If I've misunderstood the patch then I'm sorry and I'm sure that you will put me right.

     
  • Valerii Koval

    Valerii Koval - 2007-10-05
    • status: pending --> open
     
  • Valerii Koval

    Valerii Koval - 2007-10-05

    Logged In: YES
    user_id=505559
    Originator: YES

    Hi.
    1. I'm view images (slideshow).
    2. On some image I think to select this image and press IMAGE_TAG to add item to cart (no menu - I'm only view images in slideshow).
    3. After that (if I see images in second pass) I think that I must unselect that image.
    How can I do it (in slideshow process)? In that patch I add second function to AddItemToCart. This function (AddItemToCart) call not from menu, but only if I see images in slideshow process by IMAGE_TAG button press.

    Do you understand me?

     
  • Duncan Webb

    Duncan Webb - 2007-10-06

    Logged In: YES
    user_id=104395
    Originator: NO

    Now I see what you mean, but I still wont add code to an add function that causes a remove.

    I see the problem, once something is in the cart it cannot be removed. So I've fixed this and this should allow the menu to change as well.

    Hope this works as expected.

     
  • Duncan Webb

    Duncan Webb - 2007-10-06
    • status: open --> pending
     
  • Valerii Koval

    Valerii Koval - 2007-10-09

    Logged In: YES
    user_id=505559
    Originator: YES

    Small patch (name of action).
    File Added: shoppingcart.diff

     
  • Valerii Koval

    Valerii Koval - 2007-10-09
    • status: pending --> open
     
  • Valerii Koval

    Valerii Koval - 2007-10-09
     
  • Duncan Webb

    Duncan Webb - 2007-10-09
    • status: open --> pending
     
  • Duncan Webb

    Duncan Webb - 2007-10-09

    Logged In: YES
    user_id=104395
    Originator: NO

    Missed that one thanks

     
  • SourceForge Robot

    • status: pending --> closed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.