Xoops Cube Project / Bugs : Legacy / #65 XoopsMailer::send() doesn't need flush()

#65 XoopsMailer::send() doesn't need flush()

Milestone: 2.1.1

Status: closed-fixed

Owner: minahito

Labels: X2 files (35)

Priority: 7

Updated: 2007-09-22

Created: 2007-08-04

Creator: minahito

Private: No

Reported by nao-pon in
http://www.xugj.org/modules/d3forum/index.php?topic_id=454#post_id2977

Apache2 and Apache1 have difference about the behavior of flush() function. By that, when event notifications are executed in Apache2 environments, HTTP Header is sent. The cause is in XoopsMailer::send() line 332 flush().

The following comment of PHP manual explains the difference;
http://jp.php.net/manual/ja/function.ob-start.php#40861

Does XoopsMailer::send() need flush() in line 332?

Discussion

minahito - 2007-08-28

Logged In: YES
user_id=1102607
Originator: YES

Please, nobunobu, check this question at your freetime.

We don't need to fix this item rapidly. If you feel this item has to be fixed or more researched, change 'Resolution' to 'Accept'.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-08-28

assigned_to: nobody --> nobunobu

priority: 5 --> 3
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-10

status: open --> open-duplicate
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-10

Logged In: YES
user_id=1102607
Originator: YES

Duplicate:
http://sourceforge.net/tracker/index.php?func=detail&aid=1721214&group_id=159211&atid=943471

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-15

Logged In: YES
user_id=1102607
Originator: YES

Change "Assigned"

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-15

assigned_to: nobunobu --> minahito
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

GIJOE - 2007-09-19

Logged In: YES
user_id=935773
Originator: NO

flush(); in line332 looks just a bug.
Because there are no buffered data in this line.
And I've just confirmed Apache2 send headers by calling flush().
Though Apache1 does not send.

I request to remove this flush() sooner as possible (2.1.2RC2 etc.)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-22

priority: 3 --> 7

summary: Does XoopsMailer::send() need flush()? --> XoopsMailer::send() doesn't need flush()

status: open-duplicate --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-22

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-22

milestone: 731538 --> 759568
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

minahito - 2007-09-22

milestone: 759568 --> 2.1.1
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.