Menu ▾ ▴

#1762 suspect code in INST_{LIST,INVOKE_STK1}

obsolete: 8.4a4
closed-fixed
miguel sofer
47. Bytecode Compiler (220)
5
2002-02-28
2002-01-22
Don Porter
No

stackTop is decremented directly, and that
decrement is passed as an argument to a macro.

DANGER WILL ROBINSON!

Better to use the POP_OBJECT() macro defined for
this purpose.

Here's a patch.

Discussion

  • Don Porter

    Don Porter - 2002-01-22
     
    exec.patch

  • Jeffrey Hobbs

    Jeffrey Hobbs - 2002-01-22

    Logged In: YES
    user_id=72656

    Note that there are many more instances of this use that
    Don warns against in the new LIST instructions than are
    accounted for in the patch.

     

  • Don Porter

    Don Porter - 2002-02-28

    Logged In: YES
    user_id=80530

    Did this issue get resolved?

     

  • miguel sofer

    miguel sofer - 2002-02-28
    • status: open --> closed-fixed
     

  • miguel sofer

    miguel sofer - 2002-02-28

    Logged In: YES
    user_id=148712

    Now it did: exec2.patch committed

     

  • miguel sofer

    miguel sofer - 2002-02-28
     
    exec2.patch