I have written a driver for the Futuba MDM166A VFD, a nice 96x16 pixel usb vfd display with additional icons which is build into some Targa PCs and available for sale at www.eisgold.de.
Hello, thank you for your contribution and sorry for long time no answer.
I have the following remarks:
- Please create patches for new drivers against CVS-Head (aka current), not a release.
- When creating diffs please use 'unified diff' format (diff -u).
Now more technical:
- The libhid detection did not work on my system (FreeBSD 7.3) and neither CFLAGS nor LIB settings are not passed to (g)cc. As libhid only supports pkg-config system I rewrote the integration into LCDproc build system (see attached mdm166a-configure.diff).
Some comments about style:
Newly added files will be passed through 'indent' to make sure some common style is used, therefore:
- Please refrain from using C++ style comments (//), use C comments instead (/* */).
- To make sure comments and code will look like you intended, please set your editor to use TAB indention with an indention level of 8 characters.
You do not need to fully document the functions implementing the driver API, however I ask you to fully document private / driver internal functions using Doxygen comments. You may look at other drivers how to do this.
Besides that, the drivers compiles cleanly on my system. However, due to lack of hardware I cannot test it.
Thank you so far.
Markus
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hello, thank you for your contribution and sorry for long time no answer.
I have the following remarks:
- Please create patches for new drivers against CVS-Head (aka current), not a release.
- When creating diffs please use 'unified diff' format (diff -u).
Now more technical:
- The libhid detection did not work on my system (FreeBSD 7.3) and neither CFLAGS nor LIB settings are not passed to (g)cc. As libhid only supports pkg-config system I rewrote the integration into LCDproc build system (see attached mdm166a-configure.diff).
Some comments about style:
Newly added files will be passed through 'indent' to make sure some common style is used, therefore:
- Please refrain from using C++ style comments (//), use C comments instead (/* */).
- To make sure comments and code will look like you intended, please set your editor to use TAB indention with an indention level of 8 characters.
You do not need to fully document the functions implementing the driver API, however I ask you to fully document private / driver internal functions using Doxygen comments. You may look at other drivers how to do this.
Besides that, the drivers compiles cleanly on my system. However, due to lack of hardware I cannot test it.
Thank you so far.
Markus
Patch to configure system against HEAD using pkg-config
The driver has been modified to comply with the current code style guide and was committed today.