Fix renumbering of apertures when copying images
Brought to you by:
spetm,
thepurlieu
Menu
▾
▴
#18 Fix renumbering of apertures when copying images
When copying images, gerbv wouldn't renumber aperture numbers below APERTURE_MIN. This meant that they didn't get output when merging two drill files together.
I don't understand why gerbv keeps aperture numbers above 9. I couldn't find anything about this in the excellon spec.
Fix aperture renumbering when copying images
Good catch Robert. I actually recently fixed this same problem in the "duplicate_image" routine, but obviously didn't spot the same problem elsewhere. FYI, the aperture_min constant is a requirement in the RS274X spec, and we kind of treat drill and RS274x files similarly in gerbv. So, for the time being, the plan was just to move all tool numbers above 9 to make them valid as either RS274X OR drill files, since we now allow translating between the two formats in libgerbv. I've fixed in CVS.
FYI, feel free to send any patches to gerbv-devel mailing list, or directly to me if you want to avoid some of the "overhead" of submitting patches on Sourceforge. Out of curiosity, are you just tinkering with libgerbv for fun, or are you planning on using it for a full-blown project? Keep up the good work!