Menu

#62 Javascript needed

closed-fixed
None
5
2004-10-09
2002-08-30
No

Nocc needs Javascript for sending emails
or uploading attachments.

I consider is a bug as you can never rely on Javascript.
That mostly all browsers support Javascript is no point
because good firewalls or webproxys offer the possibility
to remove Javascript to increase security.

BTW: You don't need Javascript to do the job at all.
Just change the three buttons (attache, delete, submit)
into real submit buttons and give set their name
attributes to some reasonable value.
Then replace your case 'sendaction' code with some if
clauses testing on this name.
e.g if (!empty($do_send)) -> send
if (!empty($do_attach)) -> attach
do_send would be the name of the send button then.

Changing this should be a no brainer for you.

You could still leave some Javascript code to prevent
the user from unnessary uploading the attachements if
some required field (like the to fields) are missing.
As a goodie if javascript is enabled. But you should
_never rely on JS.

If you need more help to change this
please email me and I'll help you to change this.

regards
Gunnar

Discussion

  • Ross Golder

    Ross Golder - 2003-01-24

    Logged In: YES
    user_id=20872

    I hate the fact that Javascript is required for NOCC, too.
    and I would be very interested in seeing a patch for this
    (preferably against latest CVS). If you get a moment before
    I do, please submit a patch for this to our patch tracker.

    However, this _isn't_ a bug, so I'm going to re-file it as a
    feature request. At this stage, we only want to see real
    bugs in the bug list.

    --
    Ross

     
  • Ross Golder

    Ross Golder - 2003-01-24
    • labels: 104551 -->
    • milestone: 102575 -->
     
  • Anonymous

    Anonymous - 2004-06-19

    Logged In: YES
    user_id=29685

    Can you attach some patchs ?

     
  • Leif Gustafson

    Leif Gustafson - 2004-10-01

    Logged In: YES
    user_id=91655

    I have a fix for this worked out (was stuck using lynx on a
    mac running linux when I noticed this problem). I will submit
    in the near future after cleaning it up and testing.

     
  • Leif Gustafson

    Leif Gustafson - 2004-10-08

    Logged In: YES
    user_id=91655

    The javascript requirement has been eliminated in the CVS
    version as of 10-8-04

     
  • Anonymous

    Anonymous - 2004-10-09
    • assigned_to: nobody --> jdeluise
    • status: open --> open-fixed
     
  • Anonymous

    Anonymous - 2004-10-09

    Logged In: YES
    user_id=29685

    Great stuff, thanks Leif !

     
  • Anonymous

    Anonymous - 2004-10-09
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.