Menu

#2512 Bugs Generating Order from Project and Phase

open-accepted
Project (13)
3
2011-01-20
2010-09-24
No

The first one:

- When I generate a Sales Order from a Project, the Transaction that is used to save the new Order must not be the same of the used to get the Lines from Project, it was given me a error when getting the lines, the error said that the transaction was already used... the files atached explain better.

The second one:
- When i generate a Sales Order from a Project Phase, the lines that belong to this Phase are not being generated into do new Order... I implemented the method getLines() to the Project Phase in this Bug Fix 3067850, and now I use this to: When generate a order from a phase put all the items that belong to this phase into the new order....

So i just needed to change some lines in:
ProjectGenOrder.java and ProjectPhaseGenOrder.java see attaches...

Discussion

  • Marcelo Luiz Onhate

    Nobody?
    The attached patch corrects the bug

     
  • Marcelo Luiz Onhate

    Nobody?

     
  • Trifon (An ADempiere founder)

    Hi Marcelo,

    your contribution looks good.
    I will try to test it and integrate it in trunk.

    Regards,
    Trifon

     
  • Marcelo Luiz Onhate

    So.... it's a bug people... needs to be corrected...

     
  • Carlos Ruiz

    Carlos Ruiz - 2011-01-20

    Hi Marcelo, peer reviewed, tested and partially integrated in branches globalqss adempiere361:
    http://adempiere.hg.sourceforge.net/hgweb/adempiere/adempiere361/rev/4a230a05cccc

    > The first one:
    > - When I generate a Sales Order from a Project, the Transaction that is used to save the new
    > Order must not be the same of the used to get the Lines from Project, it was given me a error
    > when getting the lines, the error said that the transaction was already used... the files
    > atached explain better.

    Could not be reproduced, I enabled the hidden button and created a sales order from a project and it worked without problem. I didn't integrate this part as it's preferrably to use transactions when possible.

    > The second one:
    > - When i generate a Sales Order from a Project Phase, the lines that belong to this Phase are not being generated into
    > do new Order... I implemented the method getLines() to the Project Phase in this Bug Fix 3067850, and now I use this
    > to: When generate a order from a phase put all the items that belong to this phase into the new order....

    Reproduced and checked that your patch solves the problem, thanks for contributing.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2011-01-20
    • priority: 5 --> 3
    • assigned_to: nobody --> globalqss
    • status: open --> open-accepted
     
  • Marcelo Luiz Onhate

    Thanks !

     

Log in to post a comment.