Good idea Teo. I've attached a new patch to make all button fields with references searchable (FindButton.txt). Not sure if it will work in all cases but initial tests seemed good. It might also make sense to remove buttons without references from the list of search columns -- not sure what the best approach is there.
Regards,
Paul Bowden
P.S. Thanks for the quick review Trifon!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks Paul
Committed revision 12067 http://adempiere.svn.sourceforge.net/adempiere/?rev=12067&view=rev
reverted revision 12035
implemented new patch submitted by Paul
peer reviewed and tested (swing and zkwebui)
added migration script to fix some dictionary errors on Posted columns
Regards,
Carlos Ruiz
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Patch attached (zk solution hasn't been tested yet).
Test and committed Swing part.
Revision: 12035
http://adempiere.svn.sourceforge.net/adempiere/?rev=12035&view=rev
Trifon
Hi,
Nice work!
I was just wondering if it's not more helpful if we enable search for all button fields that have the AD_Column.AD_Reference_Value_ID not null.
WDYT?
Best regards,
Teo Sarca
Good idea Teo. I've attached a new patch to make all button fields with references searchable (FindButton.txt). Not sure if it will work in all cases but initial tests seemed good. It might also make sense to remove buttons without references from the list of search columns -- not sure what the best approach is there.
Regards,
Paul Bowden
P.S. Thanks for the quick review Trifon!
Thanks Paul
Committed revision 12067
http://adempiere.svn.sourceforge.net/adempiere/?rev=12067&view=rev
reverted revision 12035
implemented new patch submitted by Paul
peer reviewed and tested (swing and zkwebui)
added migration script to fix some dictionary errors on Posted columns
Regards,
Carlos Ruiz
integrated to release with revision 12077
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).