Improve ADempiere Web Applications

Committed with SVN Revision: 11855
http://adempiere.svn.sourceforge.net/adempiere/?rev=11855&view=rev

Trifon

Committed with SVN Revision: 11856
http://adempiere.svn.sourceforge.net/adempiere/?rev=11856&view=rev

Revision: 11857
http://adempiere.svn.sourceforge.net/adempiere/?rev=11857&view=rev

Revision: 11858
http://adempiere.svn.sourceforge.net/adempiere/?rev=11858&view=rev

Hi Trifon,

I'm not sure about the validity of revision 11855

I understand revisions 11856, 11857 and 11858 - mainly changing Adempiere by ADempiere.

But with revision 11855 mainly you dropped the "author Jorg Janke" comment from the files, for example:
http://adempiere.svn.sourceforge.net/viewvc/adempiere/trunk/webStore/src/web/invoiceLines.jsp?r1=11855&r2=11854&pathrev=11855

I think the revision 11855 is not valid, so I would recommend to revert it, and apply just the changes related to ADempiere case.

Regards,

Carlos Ruiz

integrated revisions 11856, 11857 and 11858 to release with revision 11865

rejected revision 11855 as explained on previous comment

Carlos,

>But with revision 11855 mainly you dropped the "author Jorg Janke" >comment
>from the files, for example:
>http://adempiere.svn.sourceforge.net/viewvc/adempiere/trunk/webStore/src/>web/invoiceLines.jsp?r1=11855&r2=11854&pathrev=11855

What do you win with this 3-4 lines comment in the jsp?
Do you really need them?

I'm not agree dropping credits in open source.

I think if we try to apply the same for java classes we will be breaking GPL license - not sure how is this applicable for a jsp - but as they are sources I guess it's also applicable.

Regards,

Carlos Ruiz

Carlos,

>I'm not agree dropping credits in open source.

Lines which i have dropped contain 5 useless liens of comments.
It is not about dropping GPL license or Credits.
We give credits on our web pages.

It is really pity to keep this 4-6 years old comment in the jsp files.

AFAIU, these are credits:

<!--
- Author: Jorg Janke
- Version: $Id: invoiceLines.jsp,v 1.2 2006/05/06 00:41:33 mdeaelfweald Exp $
- Adempiere ERP & CRM Smart Business Solution - Copyright (c) 1999-2003 Jorg Janke
- - -
- Web Store Invoices
-->

Bibliography:
http://en.wikipedia.org/wiki/Credits#In_computing
http://en.wikipedia.org/wiki/Attribution_\(copyright)

I'm not going to explain more something that looks so obvious for me - sorry :-(
So, if you're still in doubt - or you think these are not credits - please go to forums and ask for community opinions. Meanwhile I keep my call for revert 11855.

Regards,

Carlos Ruiz