Menu

#2340 Workflow approval bug

Core
closed-accepted
9
2010-06-29
2010-03-08
Carlos Ruiz
No

Test case reproducible in http://www.testadempiere.com/webui

Login with user GardenUser and role GardenWorld User

Create a new Requisition:
* User/Contact = GardenUser
* Requisition Line for 3 Patio Table
Complete it -> The document status will be "In Progress" (CORRECT!)

Now Create a new Requisition:
* User/Contact = GardenAdmin <--- HERE IS THE DIFFERENCE
* Requisition Line for 3 Patio Table
Complete it -> The document status will be "Complete" (WRONG!)

What I found is that GardenUser can complete requisitions over his approval amount just changing the User/Contact to GardenAdmin - then GardenAdmin approval amount applies.

Samely the "Approve Own Documents" in role is not being compared with GardenUser, but with GardenAdmin.

Regards,

Carlos Ruiz

Discussion

  • Carlos Ruiz

    Carlos Ruiz - 2010-03-08
     
  • Carlos Ruiz

    Carlos Ruiz - 2010-03-08
    • assigned_to: nobody --> globalqss
    • status: open --> open-remind
     
  • Carlos Ruiz

    Carlos Ruiz - 2010-03-08

    Uploaded file BF2965640.patch with a suggested patch.

    I would like some peer review about the approach - if it can have collateral effects.

    NOTE: Something similar was raised by kzmp here:
    https://sourceforge.net/tracker/index.php?func=detail&aid=1742751&group_id=176962&atid=879332
    With a different approach (I tested the suggestion there and didn't work).

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2010-05-31

    The proposed change is being tested on a client customization.jar

    If tests go right I'll commit in release.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2010-06-14

    Customer confirmed it's working.
    Committed bug fix on release with revision 12531

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2010-06-14
    • status: open-remind --> pending-accepted
     
  • SourceForge Robot

    • status: pending-accepted --> closed-accepted
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.