ADempiere ERP Business Suite / Feature Requests / #838 New Fin Report Amount types

#838 New Fin Report Amount types

Milestone: z_don't_use_3.5.0

Status: closed-accepted

Owner: Paul Bowden (Adaxa)

Labels: Report (30)

Priority: 5

Updated: 2010-02-17

Created: 2009-10-02

Creator: Paul Bowden (Adaxa)

Private: No

Following from discussion here:
https://sourceforge.net/projects/adempiere/forums/forum/611161/topic/3415006

There is a need for an amount type that outputs the Accounted Amount (DR-CR) Balance without changing the sign. (Currently the balance type amounts always switch sign based on the account type.)

Conversely, the quantity amount types always print the accounted quantity regardless of account type, so there needs to be a new amount type that prints the quantity according to the expected sign.

The attached patch does the following:
1. Per Carlos' suggestion, split the AmountType column into two: PAAmountType and PAPeriodType. (Retain the old column for reference.)
2. Add PAAmountType list: CreditOnly, Debit Only, Balance (expected sign), Balance (accounted sign), Quantity (expected sign), Quantity (accounted sign).
3. Add PAPeriodType list: Total, Year, Period, Natural
4. Modify the report column and line code to use the new columns.

Please review and comment.

Paul Bowden

Discussion

Paul Bowden (Adaxa) - 2009-10-02

patch against trunk

amountType.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2009-10-02

I forgot to add the sql to migrate existing data in the patch migration scripts:

update pa_reportline set paamounttype = substr(amounttype, 1,1), paperiodtype = substr(amounttype,2,1);
update pa_reportcolumn set paamounttype = substr(amounttype, 1,1), paperiodtype = substr(amounttype,2,1);

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2009-11-25

Does anyone care to comment on this -- or can I just take silence as consent? ;-)

Paul

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Enrique Ruibal - 2009-11-25

Hello Paul,

We have applied your changes in the test server of our biggest user and so far the outcome has been very good, they were able to get their trial balance as expected with the net sum to zero, wich is very good for the auditors to track major discrepancies in the general ledger.

We'd be happy to have these changes applied in trunk, it is an excellent contribution.

Regards,

Enrique Ruibal

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Trifon (An ADempiere founder) - 2009-11-27

Hi Paul,

your proposal looks good to me.
Unfortunately had no time to test, but based on Enrique comment i vote positivly.
[+1]

Regards,
Trifon

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2010-01-27

milestone: --> z_don't_use_3.5.0

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2010-01-27

I've committed this to trunk (more on the lack of any objection, than the underwhelming number of positive votes).

Revision: 11352
http://adempiere.svn.sourceforge.net/adempiere/?rev=11352&view=rev
Author: phib
Date: 2010-01-27 00:29:04 +0000 (Wed, 27 Jan 2010)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2010-02-01

Hi Paul,

Peer review for FR [2871676] New Fin Report Amount types
Applying rules I5 -> indirectly I9
http://www.adempiere.com/index.php/Release_Commit_Rules

with revision 11371
http://adempiere.svn.sourceforge.net/adempiere/?rev=11371&view=rev

Regards,

Carlos Ruiz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2010-02-01

Arrived to /release with revision 11372

Regards,

Carlos Ruiz

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Carlos Ruiz - 2010-02-01

assigned_to: nobody --> phib

status: open-accepted --> pending-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2010-02-01

status: pending-accepted --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2010-02-01

Thanks for reviewing this Carlos.

Paul Bowden

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Paul Bowden (Adaxa) - 2010-02-01

status: open-accepted --> pending-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2010-02-17

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 15 days (the time period specified by
the administrator of this Tracker).

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

SourceForge Robot - 2010-02-17

status: pending-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.