Need to remove control chars from command line
Windows visual diff and merge for files and directories
Brought to you by:
christianlist,
grimmdp
Menu
▾
▴
#1824 Need to remove control chars from command line
See Developers-forum discussion thread:
"a new feature to skip initial dialog"
https://apps.sourceforge.net/phpbb/winmerge/viewtopic.php?f=6&t=26
where user had a problem his code (accidentally) added EOL characters to command line it gave to WinMerge. And WinMerge could not parse the command line.
Which caused a confusion and user claiming WinMerge doesn't work correctly.
Strictly speaking there should not be control chars in command line. But in practice there can be due to errors in external scripts etc. And WinMerge could rightfully reject to accept such command lines. But in practice its much better to strip control characters and "just work" for users.
Maybe we could (once) show information message that the command line given is not valid since it contains control characters. So the users get some clue what is wrong. But still we should work.
Trivial fix to allow for linebreaks - Completed: At revision: 6237
Ok, that solves the problem as seen in original thread. And is definitely a good fix for branches.
Committed changelog message to trunk:
Completed: At revision: 6246
Committed to 2.12 branch:
Completed: At revision: 6247
Committed to 2.10 branch:
Completed: At revision: 6248
Yes, 2.10 branch commit is a bit questionable - this isn't a visible bug that we must fix. But then it is a trivial fix that cannot cause regressions. And it can help some users using WinMerge from scripts or other programs. So small favor for users without risks.
I'm leaving the bug item open as I think the warning would be in place for trunk development.
Blaah. Interactive messagebox (needing closing) would be bad for such scripts too.
Closing this as fixed.