WinMerge / Patches / #2620 Rescan after filter change

#2620 Rescan after filter change

Milestone: Branch_+_Trunk

Status: closed-accepted

Owner: Kimmo Varis

Labels: Usability (141)

Priority: 5

Updated: 2008-07-21

Created: 2008-07-13

Creator: Kimmo Varis

Private: No

BUG item:
#787588 Changing regular expression filter does not refresh display
http://winmerge.org/bug/787588

This patch fixes that bug and a little more. :)

We check if the file/line filter has changed. For folder compare we ask user if he wants to rescan. This is because folder compare can take a long time so we don't want to do that automatically. For file compare we do a rescan without asking.

Discussion

Kimmo Varis - 2008-07-13

Original and altered files

RescanAfterFilterChange.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-13

Logged In: YES
user_id=631874
Originator: YES

First version of the patch does not rescan file compare - for some reason. It should be right, but I don't know why it does not work.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-14

Updated patch

RescanAfterFilterChange2.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-14

Logged In: YES
user_id=631874
Originator: YES

Attaching updated patch which fixes file compare rescan. Quite a dummy bug - I did the rescan before saving new filters so of course the result didn't change...
File Added: RescanAfterFilterChange2.zip

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-15

assigned_to: nobody --> kimmov

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-15

Logged In: YES
user_id=631874
Originator: YES

Committed the patch to SVN trunk:
Completed: At revision: 5620

Leaving open for 2.10 branch checkin.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-20

Logged In: YES
user_id=631874
Originator: YES

Attaching improvement patch. This patch enables rescan of all open file- and folder-compares. And it checks if linefilters were enabled/disabled from the dialog.

File Added: LinefiltersWereEnabled.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-20

Improvement patch

LinefiltersWereEnabled.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-21

Logged In: YES
user_id=631874
Originator: YES

Update committed to SVN trunk:
Completed: At revision: 5648

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-21

status: open-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Kimmo Varis - 2008-07-21

Logged In: YES
user_id=631874
Originator: YES

Committed to 2.10 branch with trunk r5613 - Add method for getting frame type (folder/file compare).
Completed: At revision: 5653

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.