Menu

#13 strict-prototypes warning fix

open
nobody
meanwhile (6)
5
2012-08-16
2008-01-03
Anonymous
No

I looked into compiling Pidgin with -Wstrict-prototypes and got some warnings from the meanwhile headers. I'm attaching a file with my fixes to address those individual errors.

I then applied that patch to meanwhile CVS. There were some things that didn't apply cleanly, so I started looking into it and found that there were a lot of bad prototypes. I fixed them with the following command line. The second patch (which I'll attach in a moment) is from the first set of changes plus that:

grep "()" .h | grep -v "#define" | sed "s|^([^:]+). ([^ ]+)();|sed -i 's#\2();#\2(void);#' \1|" | grep -v status-changed | grep -v update_watch | bash

Discussion

  • Nobody/Anonymous

    Changes against the system headers.

     
  • Richard Laager

    Richard Laager - 2008-01-03

    Logged In: YES
    user_id=156487
    Originator: NO

    Apparently I can't attach a new file. So, if you apply the first patch and run that command, you should get the right results.

     
  • Christopher (siege) O'Brien

    Logged In: YES
    user_id=77326
    Originator: NO

    accepted for 1.1.0

     

Anonymous
Anonymous

Add attachments
Cancel