Menu

#699 VPatchFile macro does not handle spaces or absolute paths

closed-fixed
Plugin (101)
5
2007-11-10
2007-11-10
No

The VPatchFile macro in NSIS\Include\VPatchLib.nsh does not handle spaces or absolute paths. Suggest changing it to the following:

!macro VPatchFile PATCHDATA SOURCEFILE TEMPFILE
InitPluginsDir
File "/oname=$PLUGINSDIR\${TEMPFILE}.patchFile" "${PATCHDATA}"
vpatch::vpatchfile "$PLUGINSDIR\${TEMPFILE}.patchFile" "${SOURCEFILE}" "${TEMPFILE}"
Pop $1
DetailPrint $1
StrCpy $1 $1 2
StrCmp $1 "OK" +2
SetErrors
IfFileExists "${TEMPFILE}" +1 +3
Delete "${SOURCEFILE}"
Rename /REBOOTOK "${TEMPFILE}" "${SOURCEFILE}"
Delete "$PLUGINSDIR\${TEMPFILE}.patchFile"
!macroend

Discussion

  • Amir Szekely

    Amir Szekely - 2007-11-10
    • labels: 458223 --> 463802
     
  • Amir Szekely

    Amir Szekely - 2007-11-10
    • labels: 463802 --> Plugin
     
  • Amir Szekely

    Amir Szekely - 2007-11-10
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     

Log in to post a comment.