Logged In: YES
user_id=766060
Originator: YES

Summary changed

Logged In: YES
user_id=631874
Originator: NO

Yep, if the caret is in first screen (scrollbars in top position) then PgUp has no effect.

I'm afraid this is just one of those CrystalEditor bugs that have been there from the beginning.

Logged In: YES
user_id=631874
Originator: NO

This simple patch fixes it for me - and I didn't see any side-effects in short testing.

Index: ccrystaltextview2.cpp

--- ccrystaltextview2.cpp (revision 4547)
+++ ccrystaltextview2.cpp (working copy)
@@ -377,10 +377,10 @@
int nDummy;
int nNewTopLine;
GetLineBySubLine(nNewTopSubLine, nNewTopLine, nDummy);
- m_ptCursorPos.y = nNewTopLine;
ScrollToSubLine(nNewTopSubLine);
UpdateSiblingScrollPos(FALSE);
}
+ m_ptCursorPos.y = m_nTopSubLine;

// setting cursor
CPoint subLinePos;

File Added: FixPgUp.patch

Patch for PgUp handling in first screen

Logged In: YES
user_id=631874
Originator: NO

Assigning this item to me.

Logged In: YES
user_id=631874
Originator: NO

Fix committed to SVN trunk.
Completed: At revision: 4550

Leaving open for 2.6 branch commit.

Logged In: YES
user_id=631874
Originator: NO

I won't apply this for next 2.6.10 stable release.

It looks safe, but then again, this is editor code (I've caused many regressions before).. And it is not a big annoyance (nobody has reported it in many years) so stable release doesn't need it fast.

Logged In: YES
user_id=766060
Originator: YES

2.4.8 didn't have this bug.

Logged In: YES
user_id=631874
Originator: NO

Ok.

But anyway, 2.4 --> 2.6 there were so huge changes (word wrap still causing some weird problems) so it doesn't really count (other than that I was wrong when I said it was ancient bug).

And, latest 2.6.8 has been loaded over 200 000 times, and nobody reported this before - so I don't think think many users are annoyed by this bug. It is a lot safer to have this small bug than open possibility for new bugs late in stable series.

Won't apply to 2.6.x and closing this bug as fixed for 2.7.x.