Menu

#2330 Translucent LocationView

Trunk
closed-accepted
GUI (476)
5
2007-08-20
2007-08-08
No

This patch makes the visible area rect of LocationView translucent like the attached screenshot.

This patch is still buggy. I've seen graphical glitches.

Discussion

  • Takashi Sawanaka

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    File Added: locationview.PNG

     
  • Takashi Sawanaka

     
  • Kimmo Varis

    Kimmo Varis - 2007-08-08

    Logged In: YES
    user_id=631874
    Originator: NO

    Screenshot looks good. Current visible area indicator has bugs too, so all bugs may not be in your new code..

     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    I'm posting the second patch that fixes the graphical glitches.

    When restoring a background area that was dirtied by visible area indicator, if the area is not in update region on WM_PAINT event, it cannot restore the area.
    So this patch forcedly invalidates the area by calling InvalidateRect() on the OnPaint event.

    File Added: patch-locationview2.7z

     
  • Takashi Sawanaka

     
  • Kimmo Varis

    Kimmo Varis - 2007-08-20

    Logged In: YES
    user_id=631874
    Originator: NO

    Looks good. I hope this approach solves most of our problems with visible area indicator. I like how the patch removes some of my quick and hacky code. :)

    Please apply when you have time.

     
  • Takashi Sawanaka

    • labels: --> GUI
    • milestone: --> Trunk
    • assigned_to: nobody --> sdottaka
    • status: open --> closed-accepted
     
  • Takashi Sawanaka

    Logged In: YES
    user_id=954028
    Originator: YES

    Committed to SVN trunk. Completed: At revision: 4451

     

Log in to post a comment.