Menu

#117 Add time to mail view

closed-fixed
None
5
2007-06-25
2007-06-24
Tim Gerundt
No

It is a little bit unpractical that the mail view only shows the date but not the time.

This patch adds the time to the mail view, like other mail programs do:

Index: webmail/html/html_mail.php

RCS file: /cvsroot/nocc/nocc/webmail/html/html_mail.php,v
retrieving revision 1.4
diff -u -r1.4 html_mail.php
--- webmail/html/html_mail.php 23 Oct 2006 08:47:55 -0000 1.4
+++ webmail/html/html_mail.php 24 Jun 2007 20:46:25 -0000
@@ -38,7 +38,7 @@
if ($content['subject'] == '')
$content['subject'] = $html_nosubject;
echo '<tr><th class="mailHeaderLabel">'.$html_subject.':</th><td class="mailHeaderData">'.htmlspecialchars($content['subject']).'</td></tr>';
- echo '<tr><th class="mailHeaderLabel">'.$html_date.':</th><td class="mailHeaderData">'.$content['date'].'</td></tr>';
+ echo '<tr><th class="mailHeaderLabel">'.$html_date.':</th><td class="mailHeaderData">'.$content['date'].' '.$content['time'].'</td></tr>';
if($content['att'] != '') {
echo $content['att'];
}

I can commit the patch by myself, but you should say if it is ok! :)

Greetings,
Tim

Discussion

  • Tim Gerundt

    Tim Gerundt - 2007-06-24

    patch file

     
  • Anonymous

    Anonymous - 2007-06-25

    Logged In: YES
    user_id=529507
    Originator: NO

    Fixed in CVS.

    It'll be included in next release.

    But you can download daily snapshots at :
    http://nocc.sourceforge.net/download/

    Thanks for the patch.

     
  • Anonymous

    Anonymous - 2007-06-25
    • assigned_to: nobody --> goddess_skuld
    • status: open --> closed-fixed
     
  • Tim Gerundt

    Tim Gerundt - 2007-06-25

    Logged In: YES
    user_id=652377
    Originator: YES

    Btw: The functions aff_mail() and inbox() returns a "complete_date" value in their array, which has the same value like "date". Is this a bug or a feature? :)

     
  • Anonymous

    Anonymous - 2007-06-25

    Logged In: YES
    user_id=529507
    Originator: NO

    Who knows :)

    It seems to be there before the day I came to the project.

     
  • Tim Gerundt

    Tim Gerundt - 2007-06-25

    Logged In: YES
    user_id=652377
    Originator: YES

    Ok, 5 years ago NOCC saves in "complete_date" the date or the time (if the mail was from today). It was changed because of sorting problems:
    http://nocc.cvs.sourceforge.net/nocc/nocc/webmail/functions.php?r1=1.149&r2=1.150

    Since then it is needless and we can use "date" instead! I will patch it... :)

     

Log in to post a comment.