Menu

#539 "View" menu elements dont open result window

Core
closed-rejected
Heng Sin
UI Swing (244)
1
2010-03-27
2007-05-06
sernaton
No

Unless there is an obscure way of achieving this, I have been unable to, for example, open the "business partner info" or "invoice" after looking for it in the View menu.

A more exact description of what I was expecting:

1. go to "View" menu, select "business partner info" (for example), then select one of the business partners and either
a) double-click on it, or
b) select it and click on the OK botton (at the buttom-right of the window)

Any of these just closes the window. I was expecting that the "business partner info" window would be open with my selection.

The same applies for all the other options in the "View" menu, except accounts, which use a different window.

Kind regards,
carlos

Discussion

  • sernaton

    sernaton - 2007-05-06

    Logged In: YES
    user_id=1766524
    Originator: YES

    Just noticed an obscure button on the bottom that is tagged as "zoom" that is exactly what I was missing.

    I would strongly suggest nevertheless to treat this as a usability bug. Double-clicking or clicliking the "OK" button should be synonimous of the Zoom button when the window has been opened from the View menu.

    Kind regards,
    carlos

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2007-05-08

    Logged In: YES
    user_id=867558
    Originator: NO

    Yes Carlos,

    1. go to "View" menu, select "business partner info" (for example), then
    select one of the business partners and either
    a) Click on the History button (Alt-Y) or
    b) Click on the Zoom button (Alt-Z) at the bottom

    The same goes with the Invoice selection.

    At least the double click action should not exit the window. Or we do like what u and Sernation expects:

    ------------------
    * Mouse Clicked
    * @param e event
    */
    public void mouseClicked(MouseEvent e)
    {
    // log.fine( "Info.mouseClicked",
    // "ClickCount=" + e.getClickCount() + ", Right=" + SwingUtilities.isRightMouseButton(e)
    // + ", r=" + m_table.getSelectedRow() + ", c=" + m_table.getSelectedColumn());

    // Double click with selected row => exit
    if (e.getClickCount() > 1 && p_table.getSelectedRow() != -1)
    {
    zoom(); // replacing dispose(true); // double_click same as OK
    }
    -----------------

    I have tested thee "zoom()" above and it is OK. If that is ok with u Carlos the i will commit my first ever line! :D
    red1

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2007-05-08
    • assigned_to: nobody --> red1
    • status: open --> pending
     
  • Heng Sin

    Heng Sin - 2007-05-08

    Logged In: YES
    user_id=1599854
    Originator: NO

    The patch is bad as it break the existing UI semantic for lookup. Open sales order, create a new record, open the lookup dialog for business partner, retrieve record and double click on one of the row, with the patch, it will now open the business partner window instead of pass back the selected value to the sales order window.

     
  • Teo Sarca

    Teo Sarca - 2007-05-08

    Logged In: YES
    user_id=1311402
    Originator: NO

    Hi,

    I agree with you Low.

    But, what about zoom() when WindowNo==0 (the info is called from View menu), dispose() otherwise.
    Not tested...

    Best regards,
    Teo Sarca

     
  • Teo Sarca

    Teo Sarca - 2007-05-08
    • status: pending --> open
     
  • Heng Sin

    Heng Sin - 2007-05-09
    • status: open --> pending-fixed
     
  • Heng Sin

    Heng Sin - 2007-05-09

    Logged In: YES
    user_id=1599854
    Originator: NO

    yes, teo, that works!
    http://svn.sourceforge.net/adempiere/?rev=2326&view=rev

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2007-05-09

    Logged In: YES
    user_id=867558
    Originator: NO

    DeathMeat refered to me while i committed that there is possible impact, then after review he regard optiomal behaviour without us noticing SO. Thus, hengsin is rite. i tested as per SO, and it is as he stated.

    Then tried Hengsin's patch which has Teo's suggestion too. Tested with combi of various multiple windows... the behaviour is best level possible in my opinion. Regard as Hengsin's action. :D

    regards
    red1

     
  • Redhuan D. Oon

    Redhuan D. Oon - 2007-05-09
    • assigned_to: red1 --> hengsin
     
  • Teo Sarca

    Teo Sarca - 2007-05-18

    Logged In: YES
    user_id=1311402
    Originator: NO

    Hi,

    The fix still not working for folowing testcase:
    1. From Menu: View->Info Invoice
    2. Goto BPartner field and press the small button to open the Info Partner window.
    3. On Info Partner window enter some criteria, and then double click on chosen partner
    Instead of selecting the partner (what the user expects), Adempiere will open the Partner window.

    To conclude: when you use cascaded info windows, the current behaviour is bad.

    Best regards,
    Teo Sarca

     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • Teo Sarca

    Teo Sarca - 2007-05-23

    Logged In: YES
    user_id=1311402
    Originator: NO

    I am opening it because the issue is not solved. See my previous post.

    Best regards,
    Teo Sarca

     
  • Teo Sarca

    Teo Sarca - 2007-05-23
    • status: closed-fixed --> open-fixed
     
  • Teo Sarca

    Teo Sarca - 2007-05-23
    • status: open-fixed --> open
     
  • Joel Stangeland

    Joel Stangeland - 2008-01-24
    • priority: 5 --> 3
     
  • Carlos Ruiz

    Carlos Ruiz - 2010-01-28
    • priority: 3 --> 1
    • milestone: 643413 --> Core
     
  • Carlos Ruiz

    Carlos Ruiz - 2010-01-28

    Confirmed the behavior described by Teo.

    Using the OK button instead of double click work ok.

    Regards,

    Carlos Ruiz

     
  • Carlos Ruiz

    Carlos Ruiz - 2010-03-11
    • status: open --> pending-rejected
     
  • Carlos Ruiz

    Carlos Ruiz - 2010-03-11

    reversed change introduced with revision 2326.
    committed revision 11643

    this make the behavior of double click to behave as expected and consistent with zkwebui

    I don't think this is a bug

     
  • Carlos Ruiz

    Carlos Ruiz - 2010-03-15

    reversion arrived to /release with revision 11665

     
  • SourceForge Robot

    • status: pending-rejected --> closed-rejected
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     

Log in to post a comment.