Menu ▾ ▴

#131 [InstallOptions] support for linebreaks in link control

closed-accepted
Amir Szekely
Plugin (47)
5
2007-04-03
2007-03-18
No

this patch is a response to feature request #1495949:
http://sourceforge.net/tracker/index.php?func=detail&aid=1495949&group_id=22049&atid=373088

it adds linebreak support to link controls by making the MULTILINE flag available for them.

so, if you want to have multiple lines in a single link, you'll have to use:

[Field x]
Type=Link
...
Flags=MULTILINE
Text=this is a \r\n linebreak in \r\n a link control!

patch notes:
* this will break backwards compatibility regarding the usage of backslashes in link texts! you'll have to escape backslashes in links now.
* patch is against nsis cvs from march 18, 2007
* patch affects installeroptions.cpp
* patch does not include tests, examples or documentation updates

Discussion

  • Anonymous

    Anonymous - 2007-03-18

    patch for installeroptions.cpp

     
    installoptions_linebreak_for_links.patch

  • Anonymous

    Anonymous - 2007-03-18
    • assigned_to: nobody --> kichik
     

  • Amir Szekely

    Amir Szekely - 2007-04-03
    • status: open --> closed-accepted
     

  • Amir Szekely

    Amir Szekely - 2007-04-03

    Logged In: YES
    user_id=584402
    Originator: NO

    Thanks, applied. I've removed the test for MULTILINE flag because it breaks compatibility anyway and it's only logical for links to act as labels.

     

  • Anonymous

    Anonymous - 2007-04-03

    Logged In: YES
    user_id=970495
    Originator: YES

    so links work with linebreaks without using the MULTILINE flag?

     

Log in to post a comment.