This patch adds colored quotes for mails! :)
But the patch is a little bit INCOMPLETE. He missing
the complete preference part. But it is enough for test
from the colored quotes. Feel free to leave a comment
(or add the missing preference part *rofl*).
Greetings,
Tim
original and altered files
patch file
Logged In: YES
user_id=529507
Fixed in CVS.
It'll be included in next release.
But you can download daily snapshots at :
http://nocc.sourceforge.net/download/
Thanks for the patch.
Logged In: YES
user_id=652377
Do you really want to enable colored quotes for HTML mails?
I am not sure, if this will work, since the preg_replace()
search for ">" at the line beginning:
1. Since you don't use htmlspecialchars() for HTML mails,
you must search for ">" instead of ">".
2. Since a HTML can have other tags (<font>, <div>, ...) at
the line beginning, the regular expression won't work.
3. You could maybe accidentally colored some other tags.
4. You need "$user_prefs = $_SESSION['nocc_user_prefs'];"
before line 559.
Greetings,
Tim
P.S.: You forgot the delete colored quotes from the TODO
file. ;-)
Logged In: YES
user_id=652377
Ok, maybe point 1 is not correct, since a mail client must
convert this ">" self to ">" to get vaild HTML code. But
do they? I am not sure, since I don't write HTML mails. ;)
Logged In: YES
user_id=529507
I've just removed colored quotes for HTML mails as it could
be a bad idea.