Menu

#474 InstallLib misinterprets TLB version number

2.0 Series
closed-fixed
General (291)
5
2006-04-18
2006-04-16
David Rowe
No

NSIS 2.16.
I am using InstallLib to install *.ocx files, as type
REGDLLTLB. It doesn't seem to interpret the version
numbers correctly: it sometimes copies a file and
requests a reboot, even when the local and destination
files are already identical.
I believe the error is in Library.nsh, just after the
call to TypeLib::GetLibVersion. Are the major and
minor version numbers being popped off the stack in
the wrong order?

Discussion

  • Amir Szekely

    Amir Szekely - 2006-04-18
    • assigned_to: nobody --> kichik
    • status: open --> closed-fixed
     
  • Amir Szekely

    Amir Szekely - 2006-04-18

    Logged In: YES
    user_id=584402

    The minor and major stack order was indeed switched. The
    major version is pushed before the minor in TypeLib.dll, but
    Library.nsh pops the major first.

    Include/Library.nsh lines 308 and 309 should be switched.
    Pop $R3 must come first.

    Thanks.

     

Log in to post a comment.