Menu

#1042 spam filters get removed when changing other privacy pages

closed-fixed
nobody
5
2014-08-20
2005-07-01
Alex
No

Originally reported in 1020013
http://sourceforge.net/tracker/?group_id=103&atid=100103&func=detail&aid=1020013

This problem still very annoyingly ocurrs in the 2.1.6
release which appears not to include the patch
submitted. I have updated the patch against 2.1.6 and
included it below.

Discussion

  • Alex

    Alex - 2005-07-01

    Updated patch from 1020013 against 2.1.6

     
  • Alex

    Alex - 2005-07-08

    Logged In: YES
    user_id=1156173

    Unfortunately this patch does not fix all occurances of the
    problem. I can reliably "lose" all spam filters entered by
    going directly to the spam filter section after logging out.
    To reproduce:

    1. Login as list admin
    2. Goto Privacy / Spam filters and create a spam filter
    3. Logout
    4. Modify logout URL from
    .../<listname>/logout
    to
    .../<listname>/privacy/spam
    5. Enter password and observe absense of Spam filter.

    The worrying thing is that it appears to be the login
    through the privacy/spam script that kills the spam filter.

     
  • Alex

    Alex - 2005-07-08
    • milestone: 266284 -->
     
  • Tokio Kikuchi

    Tokio Kikuchi - 2005-09-21
    • status: open --> closed-fixed
     
  • Tokio Kikuchi

    Tokio Kikuchi - 2005-09-21

    Logged In: YES
    user_id=67709

    Fixed in CVS. (2.2.0a0)

     
  • Mantas K

    Mantas K - 2006-07-06

    Logged In: YES
    user_id=439618

    According to bugreporter (and my personal experience with
    mailman) spam filters still gets removed when changing other
    privacy pages in mailman 2.1.x :(
    I think this bug should be reopened and closed only when it
    will be really fixed in stable release of mailman.

     
  • Mark Sapiro

    Mark Sapiro - 2006-07-07

    Logged In: YES
    user_id=1123998

    The bug reported in the 2005-07-08 comment was fixed in
    2.1.7 as well as in the trunk (2.2.0a0).

    The bug described in report 1020013 was fixed in 2.1.6b5.
    The patch attached to this report for 2.1.6 is redundant and
    only adds a second test

    if subcat == 'spam':

    in the _handleForm() method definition when the test has
    already been applied before calling _handleForm().
    Apparently, the submitter confused the original bug which
    had been fixed differently but equivalently to the patch
    with the different bug reported in the 2005-07-08 comment.

    If you have evidence that any bug with these symptoms is
    still in 2.1.7 or 2.1.8, please submit a new report with
    supporting information as to how to reproduce it.

     

Log in to post a comment.