Menu

#377 Welcome Page icon overlap

2.0 Series
closed-fixed
Modern UI (97)
5
2005-06-19
2005-06-16
Anonymous
No

In the MUI_PAGE_WELCOME the text is running over the
icon if it's long enough e.g. Welcome to the $Name
Setup Wizard would overlap part of the MUI_ICON. Any
way to get around it?

-Aaron

Discussion

  • Amir Szekely

    Amir Szekely - 2005-06-16

    Logged In: YES
    user_id=584402

    The welcome page doesn't show the icon specified by
    MUI_ICON. What icon are you talking about?

     
  • Aaron Lee

    Aaron Lee - 2005-06-18

    Logged In: YES
    user_id=714962

    I tried with NSIS 2.0.5, there's an example called
    WelcomeFinish.nsi which shows the overlapping text on icon
    problem.

    -Aaron

     
  • Aaron Lee

    Aaron Lee - 2005-06-18

    Logged In: YES
    user_id=714962

    By the way the problem happens on 2.0.6 as well.
    -Aaron

     
  • Amir Szekely

    Amir Szekely - 2005-06-18
    • assigned_to: joostverburg --> kichik
     
  • Amir Szekely

    Amir Szekely - 2005-06-18

    possible fix

     
  • Amir Szekely

    Amir Szekely - 2005-06-18

    Logged In: YES
    user_id=584402

    Please try replacing Contrib\Modern UI\System.nsh with the
    attached file and see if it still shows.

     
  • Aaron Lee

    Aaron Lee - 2005-06-19

    Logged In: YES
    user_id=714962

    \the attached file does not fix the problem.
    -Aaron

     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    Logged In: YES
    user_id=584402

    Can you attach the compiled example?

     
  • Aaron Lee

    Aaron Lee - 2005-06-19

    Logged In: YES
    user_id=714962

    can you tell me how to attach a file? There's no attach
    button or link in this web page. You can run makensis on
    NSIS\Examples\Modern UI\WelcomeFinish.exe to reproduce it.

    ===
    ;NSIS Modern User Interface
    ;Welcome/Finish Page Example Script
    ;Written by Joost Verburg

    ;--------------------------------
    ;Include Modern UI

    !include "MUI.nsh"

    ;--------------------------------
    ;General

    ;Name and file
    Name "Modern UI Test"
    OutFile "WelcomeFinish.exe"

    ;Default installation folder
    InstallDir "$PROGRAMFILES\Modern UI Test"

    ;Get installation folder from registry if available
    InstallDirRegKey HKCU "Software\Modern UI Test" ""

    ;--------------------------------
    ;Interface Settings

    !define MUI_ABORTWARNING

    ;--------------------------------
    ;Pages

    !insertmacro MUI_PAGE_WELCOME
    !insertmacro MUI_PAGE_LICENSE "${NSISDIR}\Contrib\Modern
    UI\License.txt"
    !insertmacro MUI_PAGE_COMPONENTS
    !insertmacro MUI_PAGE_DIRECTORY
    !insertmacro MUI_PAGE_INSTFILES
    !insertmacro MUI_PAGE_FINISH

    !insertmacro MUI_UNPAGE_WELCOME
    !insertmacro MUI_UNPAGE_CONFIRM
    !insertmacro MUI_UNPAGE_INSTFILES
    !insertmacro MUI_UNPAGE_FINISH

    ;--------------------------------
    ;Languages

    !insertmacro MUI_LANGUAGE "English"

    ;--------------------------------
    ;Installer Sections

    Section "Dummy Section" SecDummy

    SetOutPath "$INSTDIR"

    ;ADD YOUR OWN FILES HERE...

    ;Store installation folder
    WriteRegStr HKCU "Software\Modern UI Test" "" $INSTDIR

    ;Create uninstaller
    WriteUninstaller "$INSTDIR\Uninstall.exe"

    SectionEnd

    ;--------------------------------
    ;Descriptions

    ;Language strings
    LangString DESC_SecDummy ${LANG_ENGLISH} "A test section."

    ;Assign language strings to sections
    !insertmacro MUI_FUNCTION_DESCRIPTION_BEGIN
    !insertmacro MUI_DESCRIPTION_TEXT ${SecDummy}
    $(DESC_SecDummy)
    !insertmacro MUI_FUNCTION_DESCRIPTION_END

    ;--------------------------------
    ;Uninstaller Section

    Section "Uninstall"

    ;ADD YOUR OWN FILES HERE...

    Delete "$INSTDIR\Uninstall.exe"

    RMDir "$INSTDIR"

    DeleteRegKey /ifempty HKCU "Software\Modern UI Test"

    SectionEnd

     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    Logged In: YES
    user_id=584402

    There is an attachment box on the bottom of this page.

    I can't reproduce this by compiling WelcomeFinish.nsi on my
    own, that's why I need you to upload a compiled version.

     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    compiled WelcomeFinish.nsi by Aaron

     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    Logged In: YES
    user_id=584402

    I can't reproduce this even with your installer. It might be
    something related to the Windows version you're using or
    maybe a 3rd party program. Are you running Windows Blinds or
    some kind of program that changes Windows visually?

    Anyway, it seems I've used the wrong id in the previous
    patch. Please try the the new one.

     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    possible fix (2nd edition)

     
  • Aaron Lee

    Aaron Lee - 2005-06-19

    Logged In: YES
    user_id=714962

    The second patch fixes the problem, now the icon no longer
    appears on the Welcome page. Thanks! What was the problem then?

     
  • Amir Szekely

    Amir Szekely - 2005-06-19
    • status: open --> closed-fixed
     
  • Amir Szekely

    Amir Szekely - 2005-06-19

    Logged In: YES
    user_id=584402

    Great!

    The icon wasn't hidden, but there was something in front of
    it. Weird that no one else has ever reported such a case...

    Anyway... I've uploaded the fix. Thanks for your report.

     

Log in to post a comment.