-
cminyard committed patchset 1865 of module OpenIPMI to the Open IPMI CVS repository, changing 2 files.
2010-01-04 14:54:43 UTC by cminyard
-
cminyard committed patchset 1864 of module OpenIPMI to the Open IPMI CVS repository, changing 2 files.
2010-01-04 14:54:32 UTC by cminyard
-
Thanks for noticing this, I've fixed it, and another bug I noticed in that routine.
2010-01-04 14:52:40 UTC by cminyard
-
I just had a look at source code file
OpenIPMI-2.0.14/lib/ipmi_smi.c,
around line 1122 is the code
cleanup_con(ipmi_con_t *ipmi)
{
smi_data_t *smi = (smi_data_t *) ipmi->con_data;
os_handler_t *handlers = ipmi->os_hnd;
if (ipmi) {
So it seems that parameter ipmi is used, then tested for NULL.
This would be much better the other way around. Suggest code rework.
2009-12-31 14:08:23 UTC by dcb314
-
cminyard committed patchset 1863 of module OpenIPMI to the Open IPMI CVS repository, changing 1 files.
2009-12-20 14:07:06 UTC by cminyard
-
Hi folks,
I occasionally find myself getting onto an intel s5000 based server via its serial-over-lan interface (the emergency backup plan) but its stopped working somewhere between 2.0.6 (an old fedora 7 machine) and 2.0.14 (fedora 10/ubuntu 9.04). Im connecting to the intel's in-built ipmi rom.
If i try from 2.0.14, i get:
$ solterm lan -U xxxx -P xxxxxx -H intelplus 1.1.1.1...
2009-11-06 15:26:37 UTC by shihan
-
Oops, forgot to mark this closed and fixed.
2009-10-19 15:19:45 UTC by cminyard
-
Ok, I've fixed this and some other similar issues in other files. The right fix was to use the variable later in the function. Thanks a bunch for pointing this out.
2009-10-19 15:19:23 UTC by cminyard
-
cminyard committed patchset 1862 of module OpenIPMI to the Open IPMI CVS repository, changing 6 files.
2009-10-19 15:18:14 UTC by cminyard
-
For source code file OpenIPMI-2.0.14/unix/posix_thread_os_hnd.c
function set_gdbm_filename
I notice the following code
nname = strdup(name);
if (!nname)
return ENOMEM;
and local variable nname is no longer used in the function.
Suggest delete dead code and remove the memory leak.
2009-10-19 09:25:21 UTC by dcb314
