-
x-mago committed patchset 422 of module api to the flickrj CVS repository, changing 1 files.
2009-11-08 21:58:00 UTC by x-mago
-
x-mago committed patchset 421 of module api to the flickrj CVS repository, changing 1 files.
2009-11-07 23:23:24 UTC by x-mago
-
PhotosInterface::getInfo should sign calls in order to work with private images. I suggest adding an api_sig parameter by inserting this code similar to the search function at line 570:
parameters.add(
new Parameter(
"api_sig",
AuthUtilities.getSignature(sharedSecret, parameters)
)
);.
2009-11-05 01:41:40 UTC by mattny
-
Thanks for the response. I'm not sure if you're planning any action as a result of this.
You could use reflective impls for these methods that avoid evaluating properties that fetch the image data from the urls. The 'transient' modifier could be used to mark property getters to ignore - this would be consistent with serialisation.
However you implement equals(), hashCode() has to be...
2009-10-30 03:01:27 UTC by richard_barnett
-
The real brake on equals() and hashCode() where the fact that they called the (deprecated) image-getters. That's odd. Somehow the unit-test has not revealed that.
An other approach to traverse the class as with reflection would make no significant difference.
I can't accept this path. Just to consider the id and secret - sure, that's easy. But that 's not sufficient.
2009-10-29 17:49:48 UTC by x-mago
-
should add auth_token when auth token is avaiable, just like getPhotos.
like this:
parameters.add(
new Parameter(
"api_sig",
AuthUtilities.getSignature(sharedSecret, parameters)
)
);
What is private photoset: a set with all private image.
2009-10-29 10:58:56 UTC by nobody
-
Forgot to mention in the last comment that I'm using rel-1-2.
I've uploaded a patch with simple impls of hashCode() & equals() for Photo; they just use the id & secret properties.
The impl of equals() isn't perfect; see http://www.artima.com/lejava/articles/equality.html for a fuller treatment.
2009-10-23 05:06:20 UTC by richard_barnett
-
I've attached a simple main which obtains a public photo from Flickr & outputs the time taken to evaluate toString() for it & to evaluate equals() on itself.
For me the output is
false
x=x?: 1031
Photo hashCode unrecognised object: java.awt.image.BufferedImage
Photo hashCode unrecognised object: sun.net.www.protocol.http.HttpURLConnection$HttpInputStream
Photo hashCode unrecognised...
2009-10-22 06:38:01 UTC by richard_barnett
-
I was able to identify one line of output at hashCode(). That's removed. Is that, what you call noisy?
Slow? In which sense? The whole Test-Case has a runtime of 0.15 seconds. Considering some overhead for JUnit I see a runtime of about 0.004 Seconds. This just as a very rough calculation.
In principle it might be possible to implement this with better performance. Send a patch and we will...
2009-10-21 17:00:39 UTC by x-mago
-
Oops, for some reason this was added as a feature request, but I intended to raise it as a bug.
2009-10-21 04:41:36 UTC by richard_barnett
