-
Bronislav,
Maybe CO_driver files are a little complicated. The reason is optimization, because there is quite a lot of traffic on RX, TX buffers. Microcontrollers with simpler CANmodule must filter out a lot of CAN messages, so this part is made as fast as possible. But this don't mean, you can't use more standard approach on better microcontrollers. If you have large enough Rx and Tx CAN...
2009-03-19 09:50:55 UTC by jani22
-
Hi Janez,
I am realizing that moving of the structures CO_CANtxMsg_t, CO_CANrxMsg_t into CO_Driver.c is not possible, because they are used in structures of CANopen stack. Furthermore CO_CANtxMsg_t doesn't contain data array, but pointer to the data buffer, which is held outside of this structure. Let me ask what was the reason for it? Is it , because you need to change data frequently? Or is...
2009-03-09 20:26:54 UTC by bgabrhelik
-
Hi Janez,
thanks for adding me as a developer of CANopenNode project. I will commit my changes later as they will be complete. Now I have local SVN repository.
Regarding Examples, yes I agree we can keep it as it is for now. Maybe I will add some code for CANopen master/client so I can test that samle.
Anyway I can warrant that the level of your programming skils is quit high. Don't be...
2009-03-05 16:25:35 UTC by bgabrhelik
-
Hi Janez,
thanks for adding me as a developer of CANopenNode project. I will commit my changes later as they will be complete. Now I have local SVN repository.
Regarding Examples, yes I agree we can keep it as it is for now. Maybe I will add some code for CANopen master/client so I can test that samle.
Anyway I can warrant that the level of your programming skils is quit high. Don't be...
2009-03-05 11:48:01 UTC by bgabrhelik
-
jani22 added bgabrhelik to the CANopenNode project.
2009-03-04 12:31:33 UTC by jani22
-
Hi Bronislav,
I have one more comment for examples. I suppose, the only different file in Example folder will be 'main.c'. All other files are quite general (they are mainly generated from Object Dictionary Editor for generic CANopen functionality.) I don't think, it would make sense to have doubled files in each subfolder.
You have another question about DISABLE_INTERRUPTS(). The...
2009-03-04 12:26:59 UTC by jani22
-
jani22 committed patchset 5 of module Object_Dictionary_Editor to the CANopenNode CVS repository, changing 1 files.
2009-03-04 12:06:30 UTC by jani22
-
jani22 committed patchset 3 of module Example to the CANopenNode CVS repository, changing 6 files.
2009-03-04 12:06:16 UTC by jani22
-
Hi Bronislav,
You really took a serious approach to the CANopenNode. Thank you for your comments.
I must say, my profession is not programming. I'm actually a self-teaching programmer, so please be patient, if you see any of mine 'custom' approaches to programming :)
1) Please feel free, if you want to make code more consistent.
2) If I understand correctly: members of any local...
2009-03-04 12:02:19 UTC by jani22
-
Janez,
I have just bumped into problem that DISABLE_INTERRUPTS() and ENABLE_INTERRUPTS() macro is used in CO_Emergency.c. I am not disabling interrupts in my implementation, but I have mutex in CO_CANmodule_t. Please, can you check necessity of such protection. It seems that the variable sendEmergency is protected, but I cannot see in the code concurent interrupt code which sets this variable.
2009-03-03 22:09:36 UTC by bgabrhelik
