From: Petri H. <phi...@us...> - 2010-01-12 16:26:55
|
I'd like to hear some comments about removing preview from mpeg-ts demuxer (9881.diff). It is definelely broken, but I don't know if removing it breaks some streams/codecs ? Second patch (9882.diff) moves DVD SPU specific code to pes header parsing, simplifying the code (?). Are there real mpeg-ts streams with DVD SPUs ? - Petri |
From: James Courtier-D. <Ja...@su...> - 2010-01-26 22:20:21
|
On 12/01/10 16:26, Petri Hintukainen wrote: > I'd like to hear some comments about removing preview from mpeg-ts > demuxer (9881.diff). It is definelely broken, but I don't know if > removing it breaks some streams/codecs ? > > Second patch (9882.diff) moves DVD SPU specific code to pes header > parsing, simplifying the code (?). > Are there real mpeg-ts streams with DVD SPUs ? > > > - Petri > > 9881.diff looks OK to me. The preview was used in xine to help initialise the downstream buffers, load the correct plugins etc. I do not think they are needed now. I have been fixing various bugs in external ffmpeg that I was using to view my HD camcorder footage. For example, segfaults when playing on a 64 bit cpu due to integer overflows. The last bit left was the problem with the demuxer, that you appear to have helped with. Thank you James |
From: James Courtier-D. <Ja...@su...> - 2010-01-26 22:27:03
|
On 26/01/10 22:20, James Courtier-Dutton wrote: > On 12/01/10 16:26, Petri Hintukainen wrote: > >> I'd like to hear some comments about removing preview from mpeg-ts >> demuxer (9881.diff). It is definelely broken, but I don't know if >> removing it breaks some streams/codecs ? >> >> Second patch (9882.diff) moves DVD SPU specific code to pes header >> parsing, simplifying the code (?). >> Are there real mpeg-ts streams with DVD SPUs ? >> >> >> - Petri >> >> >> > 9881.diff looks OK to me. > The preview was used in xine to help initialise the downstream buffers, > load the correct plugins etc. I do not think they are needed now. > > I have been fixing various bugs in external ffmpeg that I was using to > view my HD camcorder footage. > For example, segfaults when playing on a 64 bit cpu due to integer > overflows. > The last bit left was the problem with the demuxer, that you appear to > have helped with. > > Thank you > > James > > I take that back. The preview is required for mpeg1 or mpeg2 TS streams. |
From: Petri H. <phi...@us...> - 2010-01-28 11:30:11
Attachments:
ffmpeg_mpeg12.diff
|
James Courtier-Dutton wrote: > On 26/01/10 22:20, James Courtier-Dutton wrote: > > On 12/01/10 16:26, Petri Hintukainen wrote: > > > >> I'd like to hear some comments about removing preview from mpeg-ts > >> demuxer (9881.diff). It is definelely broken, but I don't know if > >> removing it breaks some streams/codecs ? > >> > >> Second patch (9882.diff) moves DVD SPU specific code to pes header > >> parsing, simplifying the code (?). > >> Are there real mpeg-ts streams with DVD SPUs ? > >> > >> > >> - Petri > >> > >> > >> > > 9881.diff looks OK to me. > > The preview was used in xine to help initialise the downstream buffers, > > load the correct plugins etc. I do not think they are needed now. > > > > I have been fixing various bugs in external ffmpeg that I was using to > > view my HD camcorder footage. > > For example, segfaults when playing on a 64 bit cpu due to integer > > overflows. > > The last bit left was the problem with the demuxer, that you appear to > > have helped with. > > > > Thank you > > > > James > > > > > I take that back. > The preview is required for mpeg1 or mpeg2 TS streams. You're right. With ffmpeg decoder mpeg1/2 decoding works quite well without preview. Decoder just does not use mpeg_parser from ff_mpeg_parser.[ch] and loses some stream information (aspect ratio ?). This should be fixed by attached hack (ffmpeg_mpeg12.diff). Is the special handling for ffmpeg mpeg12 video decoder still needed, or is the information available from ffmpeg ? With libmpeg2 decoder everything seems to be OK without preview. Maybe the function mpeg2_find_sequence_header() is obsolete and everything necessary is done in parse_chunk() too ? - Petri |