From: Maximilian S. <max...@bu...> - 2006-03-01 16:45:30
Attachments:
demux_flac.patch
|
Hi, I've added support for loading vorbis comments from flac files. The patch is against the current CVS version. Please add this... Cheers, Maximilian -- Mail: Maximilian Schwerin <msc...@us...> PGP-Key: http://www.buelowssiege.de/pubkey.asc |
From: Maximilian S. <max...@bu...> - 2006-03-01 17:08:39
Attachments:
2006-03-01_xine-lib-CVS_demux_flac.patch
|
Hi, I've added support for loading vorbis comments from flac files. The patch is against the current CVS version. Please add this... Cheers, Maximilian P.S. Please ignore any earlier mail concerning this patch that you may have received. -- Mail: Maximilian Schwerin <msc...@us...> PGP-Key: http://www.buelowssiege.de/pubkey.asc |
From: Mike M. <mi...@mu...> - 2006-03-02 03:53:26
|
Maximilian Schwerin wrote: > Hi, > > I've added support for loading vorbis comments from flac files. The > patch is against the current CVS version. > > Please add this... It works for me on my AMD64 and I suspect it also works fine on x86. But this will not work on big-endian architectures: > + uint32_t vendor_length = *((uint32_t*) ptr); In the future, rewrite using our LE_/BE_ macros. In this case: uint32_t vendor_length = LE_32(ptr); I'll correct these and commit the patch. Thanks... -- -Mike Melanson |
From: Mike M. <mi...@mu...> - 2006-03-02 04:20:53
|
Mike Melanson wrote: > In the future, rewrite using our LE_/BE_ macros. In this case: ... and pretend that you're writing for an older version of C where variables must be declared at the beginning of a scope ... and adhere a little tighter to a coding style. Other than that, keep the patches coming! :) I also added the "Comment=" field since one of my samples had it. However, neither the comment nor genre tags are showing up in xine-ui. It might be a bug elsewhere since all similar logic in the demuxer looks correct. Thanks... -- -Mike Melanson |
From: Maximilian S. <max...@bu...> - 2006-03-02 07:22:30
|
> and adhere a little tighter to a coding style. If you don't write about it (the section about coding style in the hackers guide is a bit thin), I can't know about it... But I'll try to keep it in mind ;-) -- Mail: Maximilian Schwerin <msc...@us...> PGP-Key: http://www.buelowssiege.de/pubkey.asc |
From: Maximilian S. <max...@bu...> - 2006-03-02 10:35:39
Attachments:
2006-03-02_xine-lib-CVS_demux_flac.patch
|
> I also added the "Comment=" field since one of my samples had it. > However, neither the comment nor genre tags are showing up in xine-ui. > It might be a bug elsewhere since all similar logic in the demuxer looks > correct. I've attached a patch to correct those two issues. -- Mail: Maximilian Schwerin <msc...@us...> PGP-Key: http://www.buelowssiege.de/pubkey.asc |
From: Mike M. <mi...@mu...> - 2006-03-02 14:33:38
|
Maximilian Schwerin wrote: >> I also added the "Comment=" field since one of my samples had it. >>However, neither the comment nor genre tags are showing up in xine-ui. >>It might be a bug elsewhere since all similar logic in the demuxer looks >>correct. > > > I've attached a patch to correct those two issues. What a sneaky bug. And thanks for catching the _ARTIST meta tag in the comment logic-- I deliberately changed that to try to make something happen w.r.t. the comment data (which didn't work, obviously) and forgot to change it back to _COMMENT. -- -Mike Melanson |