From: SourceForge.net <no...@so...> - 2004-07-03 12:51:25
|
Bugs item #984594, was opened at 2004-07-03 13:51 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 Category: None Group: v1-rc5 Status: Open Resolution: None Priority: 5 Submitted By: Darren Salt (dsalt) Assigned to: Nobody/Anonymous (nobody) Summary: "Permissions error" on /dev/cdrom and /dev/dvd Initial Comment: xine-lib is marking the CD/DVD permissions tests as "failed" for the wrong reasons. There is no check on errno after the open() call in both _x_health_check_cdrom() and _x_health_check_dvdrom() (src/xine-utils/xine_check.c): ENOMEDIUM, for example, is perfectly acceptable and does *not* indicate lack of any access permissions. I _think_ that it's enough to tighten the open() tests by adding "&& errno == EACCES" and to make the close() calls conditional on fd>=0. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 |
From: SourceForge.net <no...@so...> - 2004-07-03 18:34:13
|
Bugs item #984594, was opened at 2004-07-03 14:51 Message generated for change (Comment added) made by mroi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 Category: None Group: v1-rc5 Status: Open Resolution: None Priority: 5 Submitted By: Darren Salt (dsalt) >Assigned to: Michael Roitzsch (mroi) Summary: "Permissions error" on /dev/cdrom and /dev/dvd Initial Comment: xine-lib is marking the CD/DVD permissions tests as "failed" for the wrong reasons. There is no check on errno after the open() call in both _x_health_check_cdrom() and _x_health_check_dvdrom() (src/xine-utils/xine_check.c): ENOMEDIUM, for example, is perfectly acceptable and does *not* indicate lack of any access permissions. I _think_ that it's enough to tighten the open() tests by adding "&& errno == EACCES" and to make the close() calls conditional on fd>=0. ---------------------------------------------------------------------- >Comment By: Michael Roitzsch (mroi) Date: 2004-07-03 20:34 Message: Logged In: YES user_id=552060 You are right, this check is wrong. (I even found an additional copy&paste bug: _x_health_check_dvdrom() is using hc->cdrom_dev instead of hc->dvd_dev at one occasion.) But I think ENOMEDIUM is too Linux-specific and just checking for EACCESS seems too lax, because there is still ENODEV/ENXIO to handle. What do you think about the attached patch? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 |
From: SourceForge.net <no...@so...> - 2004-07-03 21:27:31
|
Bugs item #984594, was opened at 2004-07-03 13:51 Message generated for change (Comment added) made by dsalt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 Category: None Group: v1-rc5 Status: Open Resolution: None Priority: 5 Submitted By: Darren Salt (dsalt) Assigned to: Michael Roitzsch (mroi) Summary: "Permissions error" on /dev/cdrom and /dev/dvd Initial Comment: xine-lib is marking the CD/DVD permissions tests as "failed" for the wrong reasons. There is no check on errno after the open() call in both _x_health_check_cdrom() and _x_health_check_dvdrom() (src/xine-utils/xine_check.c): ENOMEDIUM, for example, is perfectly acceptable and does *not* indicate lack of any access permissions. I _think_ that it's enough to tighten the open() tests by adding "&& errno == EACCES" and to make the close() calls conditional on fd>=0. ---------------------------------------------------------------------- >Comment By: Darren Salt (dsalt) Date: 2004-07-03 22:27 Message: Logged In: YES user_id=294680 Seems fine :-) (Unlike the HTTP headers for the patch...) ---------------------------------------------------------------------- Comment By: Michael Roitzsch (mroi) Date: 2004-07-03 19:34 Message: Logged In: YES user_id=552060 You are right, this check is wrong. (I even found an additional copy&paste bug: _x_health_check_dvdrom() is using hc->cdrom_dev instead of hc->dvd_dev at one occasion.) But I think ENOMEDIUM is too Linux-specific and just checking for EACCESS seems too lax, because there is still ENODEV/ENXIO to handle. What do you think about the attached patch? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 |
From: SourceForge.net <no...@so...> - 2004-07-04 21:02:06
|
Bugs item #984594, was opened at 2004-07-03 14:51 Message generated for change (Comment added) made by mroi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 Category: None Group: v1-rc5 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Darren Salt (dsalt) Assigned to: Michael Roitzsch (mroi) Summary: "Permissions error" on /dev/cdrom and /dev/dvd Initial Comment: xine-lib is marking the CD/DVD permissions tests as "failed" for the wrong reasons. There is no check on errno after the open() call in both _x_health_check_cdrom() and _x_health_check_dvdrom() (src/xine-utils/xine_check.c): ENOMEDIUM, for example, is perfectly acceptable and does *not* indicate lack of any access permissions. I _think_ that it's enough to tighten the open() tests by adding "&& errno == EACCES" and to make the close() calls conditional on fd>=0. ---------------------------------------------------------------------- >Comment By: Michael Roitzsch (mroi) Date: 2004-07-04 23:01 Message: Logged In: YES user_id=552060 Don't know what your problem with HTTP is, the file loads fine here. Maybe you mean the RCS header, but that's ok as well, since the patch was generated with "cvs diff". The patch tool ignores leading garbage automatically. Anyway, the patch is in CVS now, so I close this bug. ---------------------------------------------------------------------- Comment By: Darren Salt (dsalt) Date: 2004-07-03 23:27 Message: Logged In: YES user_id=294680 Seems fine :-) (Unlike the HTTP headers for the patch...) ---------------------------------------------------------------------- Comment By: Michael Roitzsch (mroi) Date: 2004-07-03 20:34 Message: Logged In: YES user_id=552060 You are right, this check is wrong. (I even found an additional copy&paste bug: _x_health_check_dvdrom() is using hc->cdrom_dev instead of hc->dvd_dev at one occasion.) But I think ENOMEDIUM is too Linux-specific and just checking for EACCESS seems too lax, because there is still ENODEV/ENXIO to handle. What do you think about the attached patch? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=109655&aid=984594&group_id=9655 |