From: <bug...@xi...> - 2009-10-05 00:20:29
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Summary: XML lexer and parser are not thread-safe Product: xine-lib Version: unspecified Platform: i386/x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P3 Component: Core / Backend AssignedTo: xin...@xi... ReportedBy: kr...@ft... The XML lexer and parser in src/xine-utils/xmllexer.[ch] and src/xine-utils/xmlparser.[ch], respectively, are not thread-safe because they use static variables to store the lexer and parser state, respectively. I've created a patch to address this issue for the copies of these modules used in totem-pl-parser (cf. https://bugzilla.gnome.org/show_bug.cgi?id=572705) and I'll submit a version for xine-lib as soon as I finish porting it. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-05 03:39:01
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #1 from Matt Kraai <kr...@ft...> 2009-10-05 03:38:47 UTC --- Created an attachment (id=162) --> (http://bugs.xine-project.org/attachment.cgi?id=162) Make XML lexer and parser thread-safe -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-05 09:43:49
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Bastien Nocera <ha...@ha...> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ha...@ha... -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-13 18:06:30
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #2 from Darren Salt <li...@yo...> 2009-10-13 18:06:19 UTC --- NAK. This patch introduces an incompatible ABI change; publicly-visible functions have different signatures. Applying this would, for example, break gxine. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-13 23:08:16
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #3 from Bastien Nocera <ha...@ha...> 2009-10-13 23:08:03 UTC --- And just how would one implement thread-safety without changing the API? -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-14 01:05:03
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Darren Salt <li...@yo...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 --- Comment #4 from Darren Salt <li...@yo...> 2009-10-14 01:04:42 UTC --- Renaming them and re-adding the old ones as (deprecated) wrappers should suffice. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-14 10:49:11
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #5 from Matt Kraai <kr...@ft...> 2009-10-14 10:48:59 UTC --- (In reply to comment #4) > Renaming them and re-adding the old ones as (deprecated) wrappers should > suffice. I believe that there need to be new versions of the following functions: * lexer_init * lexer_get_token_d * xml_parser_init * xml_parser_build_tree What would you like their new replacements to be named? -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-14 17:13:14
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #6 from Darren Salt <li...@yo...> 2009-10-14 17:13:03 UTC --- Append "_r", I think; this follows the likes of strtok → strtok_r. The wrappers should be marked with XINE_DEPRECATED. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-15 11:31:41
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Matt Kraai <kr...@ft...> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162 is|0 |1 obsolete| | --- Comment #7 from Matt Kraai <kr...@ft...> 2009-10-15 11:31:33 UTC --- Created an attachment (id=163) --> (http://bugs.xine-project.org/attachment.cgi?id=163) Make the XML lexer and parser reentrant -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-15 21:24:30
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Darren Salt <li...@yo...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #8 from Darren Salt <li...@yo...> 2009-10-15 21:17:47 UTC --- Patch committed; looks fine now (and gxine doesn't segfault with it). -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-20 03:10:57
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Matt Kraai <kr...@ft...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #9 from Matt Kraai <kr...@ft...> 2009-10-20 03:10:43 UTC --- It turns out that the XML lexer and parser in totem-pl-parser are taken from xine-lib 1.2, so I've ported the patch to that version of xine-lib. I hope it's OK to reopen this bug report and attach it here. -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-10-20 03:12:23
|
http://bugs.xine-project.org/show_bug.cgi?id=281 --- Comment #10 from Matt Kraai <kr...@ft...> 2009-10-20 03:12:08 UTC --- Created an attachment (id=164) --> (http://bugs.xine-project.org/attachment.cgi?id=164) Make the 1.2 XML lexer and parser reentrant -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |
From: <bug...@xi...> - 2009-12-01 15:12:43
|
http://bugs.xine-project.org/show_bug.cgi?id=281 Darren Salt <li...@yo...> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #11 from Darren Salt <li...@yo...> 2009-12-01 15:12:29 UTC --- (In reply to comment #10) > Created an attachment (id=164) --> (http://bugs.xine-project.org/attachment.cgi?id=164) [details] > Make the 1.2 XML lexer and parser reentrant For some reason, I didn't see any mail about this :-| Anyway, I ported the 1.1 changes when doing a merge about a month ago; 1.2 should be fine, so I'm closing this. If I've missed anything, let me know (no need to re-open this). -- Configure bugmail: http://bugs.xine-project.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are watching all bug changes. |