#329 2.0.3 doesn't expand ~ for other users

closed-fixed
nobody
None
5
2003-08-01
2003-07-08
Neox
No

~user/ should expand to user's home dir, but it expands
to the current users home dir with 'user' stuck on the end.

Discussion

  • Peter Zelezny.
    Peter Zelezny.
    2003-07-08

    Logged In: YES
    user_id=5012

    The memmove() line of your patch could read beyond the
    bounary of 'file'
    (when the strchr doesn't fail).

     
  • Neox
    Neox
    2003-07-08

    Logged In: YES
    user_id=29056

    thanks! here's an updated patch...

     
  • Peter Zelezny.
    Peter Zelezny.
    2003-07-08

    Logged In: YES
    user_id=5012

    user = strchr(file, ',') != NULL ? strchr(file,'/') : file;

    Why check for a comma? Seems like a mistake to me.

     
  • Neox
    Neox
    2003-07-08

    Logged In: YES
    user_id=29056

    right again, this was at 7am, sorry! version 3...

     
  • Neox
    Neox
    2003-07-08

    patch 3

     
  • Peter Zelezny.
    Peter Zelezny.
    2003-07-10

    Logged In: YES
    user_id=5012

    Ok, now commited to cvs, thanks.

     
  • Peter Zelezny.
    Peter Zelezny.
    2003-07-10

    • status: open --> open-fixed
     
  • Peter Zelezny.
    Peter Zelezny.
    2003-08-01

    • status: open-fixed --> closed-fixed