XASTIR / Bugs / #544 install-exec-hook fails to respect DESTDIR

#544 install-exec-hook fails to respect DESTDIR

Milestone: V2.0.4

Status: closed

Owner: Curt Mills

Labels: Compile Error (15)

Priority: 5

Updated: 2012-12-04

Created: 2010-05-19

Creator: Thomas Beierlein

Private: No

The install-exec-hooks in Makefile.am and in config/Makefile.am each calls 'rm -a ...' . If you use DESTDIR to install the package it gets not respected by the hooks and may lead to access violations.

According to automake manual section 11.4 lst sentence you have to code $(DESTDIR) explicitly into the hook rules. Attached patch fixes the problem.

Discussion

Thomas Beierlein - 2010-05-19

Fix to respect DESTDIR

xastir-1.9.8-Destdir.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Russo - 2012-08-27

This was fixed in Xastir CVS on 9 Nov 2010, shortly after the 2.0.0 release.

There has been no stable snapshot or release since then, so the fix is only available in CVS.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Beierlein - 2012-12-04

In Xastir-2.0.2 the problem still exists:

line 96 in config/Makefile.am reads

rm -f \$(configdir)/nwsfz_ddmmyy.dbfawk

but should be

rm -f $(DESTDIR)$(configdir)/nwsfz_ddmmyy.dbfawk

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Russo - 2012-12-04

Yes, thank you for pointing out that oversight. The main Makefile.am was fixed and the bug got closed, but the config/Makefile.am was overlooked. The bug has been fixed in Xastir CVS as of right now.

There should be another development snapshot tarball created ASAP, since DESTDIR issues like this are mostly important to people creating distro-specific binary packages, and those folks will pretty much never use CVS code to generate the packages.

Apologies for the inconvenience.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Beierlein - 2012-12-04

That is why I asked. I am maintaining xastir in Gentoo :-). Thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Russo - 2012-12-04

assigned_to: Curt Mills

milestone: --> V2.0.4
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Tom Russo - 2012-12-04

Curt is going to push out a 2.0.4 patch release, and says he should have it done sometime tomorrow. You should watch the Xastir users mailing list for the announcement, and not bother making a Gentoo 2.0.2 binary package.

There is another makefile-related error in 2.0.2 for which the fix is worth getting in your next package anyway. That error made Xastir's scripts get installed without proper execute permissions.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Curt Mills - 2012-12-04

I pushed out a 2.0.4 release to SourceForge this afternoon and made it the default download for all OS'es.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thomas Beierlein - 2012-12-05

Thanks for the information Tom and all the work you and Curt put into
xastir.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.