#4 Missing quotas in flacpcm

[jmilus]

In the flacpcm file the flac is called by this:

flac -d $var -c --endian=big --force-raw-format --sign=signed

Because there is no protection around $var the filenames and directories whose contains spaces are interpreted as more individual switches, that's why it is not working. The right form is:

flac -d "$var" -c --endian=big --force-raw-format --sign=signed

[Ross Nye]

Logged In: YES
user_id=1917928
Originator: NO

Yes, I had read in the forum that the following worked. It did not work for me.

flac -d "$1" -c --endian=big --force-raw-format --sign=signed

However the following flacpcm script works.

#!/bin/bash
var=${1%\"}
var=${var#\"}
flac -d "$var" -c --endian=big --force-raw-format --sign=signed

I found no need for the original authors path statement (that path doesn't exist here) nor his comments, as i didnt really understand them. Not being familar with bash scripts I don't know what the var declarations are doing, but it's sure something because without them the script still fails with paths with a space in them.

Would this mean the oggpcm script will fail too as it just passes the command arg $1 without modification. I don't use the ogg format at present so haven't tested it.

ern