Menu ▾ ▴

#48 Incorrect type (narrowing) for tool ID in tooltips

Unstable (example)
closed-fixed
Nenad Stefanovic
None
5
2015-09-17
2015-04-09
Anonymous
No

nIDTool/nTool parameters used in CToolTipCtrlT/CToolInfo are defined as UINT, however this parameter can hold HWND, and thus it is defined as UINT_PTR in Windows SDK. WTL wrappers should be updated from UINT to UINT_PTR as well.

Discussion

  • Anonymous

    Anonymous - 2015-04-09

    patch attached

     
    atlctrls.h.patch

  • Anonymous

    Anonymous - 2015-04-09

    P.S. TooltipCtrlT.SetTitle should also have UINT_PTR for nIcon parameter, otherwise HICON won't get through on Win64.

     

  • Nenad Stefanovic

    Nenad Stefanovic - 2015-09-15
    • assigned_to: Bjarke Viksøe --> Nenad Stefanovic
     

  • Nenad Stefanovic

    Nenad Stefanovic - 2015-09-17
    • status: open --> closed-fixed
     

  • Nenad Stefanovic

    Nenad Stefanovic - 2015-09-17

    Thanks for reporting this, and your patch. Fixed as proposed.

    atlctrls.h, rev 624

     

Anonymous
Anonymous

Add attachments
Cancel