several static code analysis tools report warnings in some WTL headers:
- exception specification mismatch between base and overriding function
- sizeof with type must have braces
- nested if/else should have braces for readability
The attached patch fixes them.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
several static code analysis tools report warnings in some WTL headers:
- exception specification mismatch between base and overriding function
- sizeof with type must have braces
- nested if/else should have braces for readability
Hi,
several static code analysis tools report warnings in some WTL headers:
- exception specification mismatch between base and overriding function
- sizeof with type must have braces
- nested if/else should have braces for readability
The attached patch fixes them.
Hi Marcel,
Thanks for the info and the patch file. We'll fix those warnings.
Cheers,
Nenad
On Wed, Jul 2, 2014 at 3:26 PM, Marcel Raad marcelraad@users.sf.net wrote:
Warning fix attached
Hi Nenad,
I just noticed that atlctrlx.h doesn't compile with /Zc:strictStrings. Could you fix that too please? Patch attached. Thank you very much!
Hi Marcel,
Thanks for this one too! It will be fixed.
Cheers,
Nenad
On Tue, Jul 8, 2014 at 3:15 PM, Marcel Raad marcelraad@users.sf.net wrote:
I hope I fixed them all - commit #591
Cheers,
Nenad
On Wed, Jul 9, 2014 at 12:44 AM, Nenad Stefanović nenad2001@gmail.com
wrote:
All warnings and errors are gone, thanks a lot!
Great, thanks!
On Mon, Jul 14, 2014 at 2:31 PM, Marcel Raad marcelraad@users.sf.net
wrote: