From: Anjo K. <kr...@lo...> - 2006-07-05 10:30:51
|
All, I finally got around to refactor the logging in Wonder. When I wrote ERXLogger (I was young and innocent and just started out with Wonder), the idea was that you could attach a logger to multiple nodes in the logging tree and also to abstract from the underlying implementation, so you can use either the java.util and the org.apache.log4j loggers. ERXLogger failed on both accounts and instead introduced a few very nasty load-order issues. So I now made all the changes inside of Wonder to replace all calls to ERXLogger log = ERXLogger.getERXLogger(...) with import org.apache.log4j.Logger; ... Logger log = Logger.getLogger(...) and dropped the ERXLogger log = ERXLogger.getERXLogger(clazz, "somecats") syntax. The now-unused methods still there in ERXLogger and still work (or should, at least), but they are no longer called inside of Wonder. What this means for you is: - you may need to recompile all your code, in case you inherited some component and are calling the super's public "log" method. - you will have to change all "ERXLogger tmp = SomeClass.log;" as these are no longer ERXLoggers. But chances are you were just using "SomeClass.log.debug(...)" anyway. - unless you know what a Logger factory is, chances are you're not affected anyway - if you can do a regex search-replace, you might change all of ERXLogger\s+(\w+)\s+ERXLogger.getERXLogger\(\s*(\w+)(,\s*\w+)?\)\; with org.apache.log4j.Logger \1 org.apache.log4j.Logger.getLogger(\2); (I just typed this in Mail, may or may not work) I have not yet committed this change, but will do so in the next few days, unless someone steps forth and makes a strong case against it. Cheers, Anjo |
From: Anders P. <ap...@op...> - 2006-07-05 10:45:28
|
Great! If/when I use WOLips; can I then set the WO logging options in the launch configuration? I currently have problems with this. What ever I set there is overwritten by something else. /Anders Anjo Krank wrote: > All, > > I finally got around to refactor the logging in Wonder. When I wrote > ERXLogger (I was young and innocent and just started out with > Wonder), the idea was that you could attach a logger to multiple > nodes in the logging tree and also to abstract from the underlying > implementation, so you can use either the java.util and the > org.apache.log4j loggers. > > ERXLogger failed on both accounts and instead introduced a few very > nasty load-order issues. So I now made all the changes inside of > Wonder to replace all calls to > > ERXLogger log = ERXLogger.getERXLogger(...) > > with > > import org.apache.log4j.Logger; > ... > Logger log = Logger.getLogger(...) > > and dropped the > > ERXLogger log = ERXLogger.getERXLogger(clazz, "somecats") > > syntax. The now-unused methods still there in ERXLogger and still > work (or should, at least), but they are no longer called inside of > Wonder. > > What this means for you is: > > - you may need to recompile all your code, in case you inherited some > component and are calling the super's public "log" method. > - you will have to change all "ERXLogger tmp = SomeClass.log;" as > these are no longer ERXLoggers. But chances are you were just using > "SomeClass.log.debug(...)" anyway. > - unless you know what a Logger factory is, chances are you're not > affected anyway > - if you can do a regex search-replace, you might change all of > > ERXLogger\s+(\w+)\s+ERXLogger.getERXLogger\(\s*(\w+)(,\s*\w+)?\)\; > > with > > org.apache.log4j.Logger \1 org.apache.log4j.Logger.getLogger(\2); > > (I just typed this in Mail, may or may not work) > > I have not yet committed this change, but will do so in the next few > days, unless someone steps forth and makes a strong case against it. > > Cheers, Anjo > > > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 -- http://ojalgo.org/ Mathematics, Linear Algebra and Optimisation with Java |
From: Ian J. <ian...@sp...> - 2006-07-06 01:45:37
|
Thanks, this is actually tidier because I don't have to think about =20 whether to use Logger for Java Client stuff and ERXLogger for server =20 woas =96 now I just use Logger for everything. Ian On 05/07/2006, at 8:30 PM, Anjo Krank wrote: > All, > > I finally got around to refactor the logging in Wonder. When I wrote > ERXLogger (I was young and innocent and just started out with > Wonder), the idea was that you could attach a logger to multiple > nodes in the logging tree and also to abstract from the underlying > implementation, so you can use either the java.util and the > org.apache.log4j loggers. > > ERXLogger failed on both accounts and instead introduced a few very > nasty load-order issues. So I now made all the changes inside of > Wonder to replace all calls to > > ERXLogger log =3D ERXLogger.getERXLogger(...) > > with > > import org.apache.log4j.Logger; > ... > Logger log =3D Logger.getLogger(...) > > and dropped the > > ERXLogger log =3D ERXLogger.getERXLogger(clazz, "somecats") > > syntax. The now-unused methods still there in ERXLogger and still > work (or should, at least), but they are no longer called inside of > Wonder. > > What this means for you is: > > - you may need to recompile all your code, in case you inherited some > component and are calling the super's public "log" method. > - you will have to change all "ERXLogger tmp =3D SomeClass.log;" as > these are no longer ERXLoggers. But chances are you were just using > "SomeClass.log.debug(...)" anyway. > - unless you know what a Logger factory is, chances are you're not > affected anyway > - if you can do a regex search-replace, you might change all of > > ERXLogger\s+(\w+)\s+ERXLogger.getERXLogger\(\s*(\w+)(,\s*\w+)?\)\; > > with > > org.apache.log4j.Logger \1 org.apache.log4j.Logger.getLogger(\2); > > (I just typed this in Mail, may or may not work) > > I have not yet committed this change, but will do so in the next few > days, unless someone steps forth and makes a strong case against it. > > Cheers, Anjo > > > Using Tomcat but need to do more? Need to support web services, =20 > security? > Get stuff done quickly with pre-integrated technology to make your =20 > job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache =20 > Geronimo > http://sel.as-us.falkag.net/sel?=20 > cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D121642 > _______________________________________________ > Wonder-disc mailing list > Won...@li... > https://lists.sourceforge.net/lists/listinfo/wonder-disc > |
From: Anjo K. <kr...@lo...> - 2006-07-07 19:27:05
|
OK, the change is in. Again: you *should* not need tio change anything unless you were =20 referencing loggers from your super class or other classes (which you =20= shouldn't do anyway) So please report any problems you run into. Cheers, Anjo Am 06.07.2006 um 03:45 schrieb Ian Joyner: > Thanks, this is actually tidier because I don't have to think about > whether to use Logger for Java Client stuff and ERXLogger for server > woas =96 now I just use Logger for everything. > > Ian > > On 05/07/2006, at 8:30 PM, Anjo Krank wrote: > >> All, >> >> I finally got around to refactor the logging in Wonder. When I wrote >> ERXLogger (I was young and innocent and just started out with >> Wonder), the idea was that you could attach a logger to multiple >> nodes in the logging tree and also to abstract from the underlying >> implementation, so you can use either the java.util and the >> org.apache.log4j loggers. >> >> ERXLogger failed on both accounts and instead introduced a few very >> nasty load-order issues. So I now made all the changes inside of >> Wonder to replace all calls to >> >> ERXLogger log =3D ERXLogger.getERXLogger(...) >> >> with >> >> import org.apache.log4j.Logger; >> ... >> Logger log =3D Logger.getLogger(...) >> >> and dropped the >> >> ERXLogger log =3D ERXLogger.getERXLogger(clazz, "somecats") >> >> syntax. The now-unused methods still there in ERXLogger and still >> work (or should, at least), but they are no longer called inside of >> Wonder. >> >> What this means for you is: >> >> - you may need to recompile all your code, in case you inherited some >> component and are calling the super's public "log" method. >> - you will have to change all "ERXLogger tmp =3D SomeClass.log;" as >> these are no longer ERXLoggers. But chances are you were just using >> "SomeClass.log.debug(...)" anyway. >> - unless you know what a Logger factory is, chances are you're not >> affected anyway >> - if you can do a regex search-replace, you might change all of >> >> ERXLogger\s+(\w+)\s+ERXLogger.getERXLogger\(\s*(\w+)(,\s*\w+)?\)\; >> >> with >> >> org.apache.log4j.Logger \1 org.apache.log4j.Logger.getLogger(\2); >> >> (I just typed this in Mail, may or may not work) >> >> I have not yet committed this change, but will do so in the next few >> days, unless someone steps forth and makes a strong case against it. >> >> Cheers, Anjo >> >> >> Using Tomcat but need to do more? Need to support web services, >> security? >> Get stuff done quickly with pre-integrated technology to make your >> job easier >> Download IBM WebSphere Application Server v.1.0.1 based on Apache >> Geronimo >> http://sel.as-us.falkag.net/sel? >> cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D121642 >> _______________________________________________ >> Wonder-disc mailing list >> Won...@li... >> https://lists.sourceforge.net/lists/listinfo/wonder-disc >> > > > Using Tomcat but need to do more? Need to support web services, =20 > security? > Get stuff done quickly with pre-integrated technology to make your =20 > job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache =20 > Geronimo > http://sel.as-us.falkag.net/sel?=20 > cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=3D121642 > _______________________________________________ > Wonder-disc mailing list > Won...@li... > https://lists.sourceforge.net/lists/listinfo/wonder-disc |