Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2830 wordbreak

Trunk
closed-wont-fix
nobody
None
5
2009-03-26
2009-03-26
Matthias
No

in case user is deleting all char from the custom breakvalue. This keeps empty.
With this patch in that case the standard value ",.;:" will be given as default.

Discussion

  • Matthias
    Matthias
    2009-03-26

    options default

     
    Attachments
  • Kimmo Varis
    Kimmo Varis
    2009-03-26

    Wrong. If user wants empty separators he must get empty separators. Empty meaning space and tab being in the list.

     
  • Kimmo Varis
    Kimmo Varis
    2009-03-26

    I just added unit tests for empty punct chars case and it seems to work fine. So I don't think there is anything to fix.

     
  • Matthias
    Matthias
    2009-03-26

    What to you expect in BreakChars if user is cleaning user defined chars?
    the default ",.;:"?

    But realy it's empty!
    so the only breakchar is space!

     
  • Kimmo Varis
    Kimmo Varis
    2009-03-26

    If user says "I don't want any break chars" and sets the field empty the right thing to do is set the break chars empty. Very simple.

     
  • Matthias
    Matthias
    2009-03-26

    that's the point I don't agree.
    For that he will change to space and not to interpuntion.
    So I think min one char must be there, or default.
    (also he would have no change to put standart).

     
  • Kimmo Varis
    Kimmo Varis
    2009-03-26

    Do you think users are idiots? Users can't configure WinMerge as they wish but we must alter their selections since we think we know better than they do?

    I'm not wasting more time with this (and I decide these things, remember that).

     
  • Kimmo Varis
    Kimmo Varis
    2009-03-26

    • status: open --> closed-wont-fix
     
  • Matthias
    Matthias
    2009-03-26

    ok, reject and close it.