Menu

#255 files differing not in main stream flagged as identical

Trunk
open-postponed
nobody
3
2003-10-05
2003-07-28
No

WinMerge does not know that files may have multiple
streams on NTFS.

echo "nice same " > t1.txt
echo "other" >> t1.txt:hidden
echo "nice same" > t2.txt

Compare t1.txt and t2.txt, and WinMerge will say that
they are identical.

I suppose this is debatable, but I think it would be
nice if WinMerge at least said something in this case.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2003-08-18
    • milestone: --> Trunk
     
  • Kimmo Varis

    Kimmo Varis - 2003-08-18

    Logged In: YES
    user_id=631874

    Can diff code made to detect these streams without extra
    hacks? Or can this be solved with preprocessing files?

     
  • Anonymous

    Anonymous - 2003-08-18

    Logged In: YES
    user_id=60964

    Now that we're only calling the diff code with each
    individual file, we could add code to check for and flag
    files with extra streams. I'd like to at least have a flag
    set in their properties, to be later optionally displayed in
    the dirview ?

     
  • Kimmo Varis

    Kimmo Varis - 2003-08-18

    Logged In: YES
    user_id=631874

    I think we have to change that dirview struct. Currently
    there is that "BYTE code" which tells status. But thats
    clearly not enough. We need flags for binary, folder, left
    item missing etc. Then maybe different flags for read-only,
    extra streams etc.

    For example, instead of FILE_BINDIFF we should have
    FILE_LEFT | FILE_RIGHT | FILE_BINARY | FILE_DIFF. Currently
    we cannot sort by binary status or by left unique status.

    Thats big and risky change... But worth of it?

     
  • Anonymous

    Anonymous - 2003-08-18

    Logged In: YES
    user_id=60964

    I am in favor of expanding the dirview as you say.
    Maybe this is the wrong place for such a discussion however :)

     
  • Anonymous

    Anonymous - 2003-08-23
    • status: open --> open-postponed
     
  • Anonymous

    Anonymous - 2003-08-23

    Logged In: YES
    user_id=60964

    Ok, now that we have attribute columns, how about attribute
    codes for some of these things, eg,

    RO = readonly
    STR = has streams
    SPA = sparse file

    They'd go together in one column a lot better if they were
    single letter, but, it isn't obvious what are good letters
    for them in English :(

    Ok, I'm going to go create threads for these two somewhat
    independent things on the forum (and mark this bug postponed
    as well).

     
  • Kimmo Varis

    Kimmo Varis - 2003-09-10
    • labels: --> 559476
    • priority: 5 --> 3
     
  • Kimmo Varis

    Kimmo Varis - 2003-09-10

    Logged In: YES
    user_id=631874

    Decreasing priority. This is mostly "nice to have" fix, not
    an issue for most users. If you disagree please add comment.

     
  • Anonymous

    Anonymous - 2003-09-10

    Logged In: YES
    user_id=60964

    I concur, and thanks for doing triage!

     
  • Christian List

    Christian List - 2003-10-05
    • labels: 559476 --> DIFF Engine
     

Log in to post a comment.