Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#1649 File saving error messagebox clips text

Trunk
closed-fixed
Jochen Tucht
GUI (515)
6
2008-01-20
2008-01-18
Kimmo Varis
No

Current SVN trunk (r4926).

While developing conflict file resolving code, I tried to create resolved file into my temp folder in C:\temp. Something gone wrong with saving and error message box appeared. Unfortunately last line of text in that message box is clipped.

See the attached screenshot.

Discussion

  • Kimmo Varis
    Kimmo Varis
    2008-01-18

    Screenshot of messagebox with clipped text

     
    Attachments
  • Kimmo Varis
    Kimmo Varis
    2008-01-19

    • assigned_to: nobody --> jtuc
     
  • Kimmo Varis
    Kimmo Varis
    2008-01-19

    Logged In: YES
    user_id=631874
    Originator: YES

    Jochen, can this have something to do with new translation system?

    String in resource looks ok.

     
  • Jochen Tucht
    Jochen Tucht
    2008-01-20

    Logged In: YES
    user_id=766060
    Originator: NO

    This bug actually dates back to 2.4.0. But the fix is obvious.

    Completed: At revision: 4932

     
  • Kimmo Varis
    Kimmo Varis
    2008-01-20

    • status: open --> closed-fixed
     
  • Kimmo Varis
    Kimmo Varis
    2008-01-20

    Logged In: YES
    user_id=631874
    Originator: YES

    Hmm. I'm pretty sure I've been testing that dialog many many times as I worked through the file saving code to handle all kinds of situations. But something has changed since then, and I think those tabulators were added to text much later.

    Anyway, thanks for fixing this.

     
  • Jochen Tucht
    Jochen Tucht
    2008-01-21

    Logged In: YES
    user_id=766060
    Originator: NO

    When you ran your tests, texts substituted for %1 and %2 were probably long enough to prevent subsequent lines from being broken.

     
  • Kimmo Varis
    Kimmo Varis
    2008-01-21

    Logged In: YES
    user_id=631874
    Originator: YES

    True, I thought about that after writing previous comment. In the buggy message the third line that should have an error message is missing - which is a bug in itself. But as this whole message was caused by me messing temp files logic, its not worth looking further.