#23 HTTPRequest _action_ and image submit

closed-rejected
Geoff Talvola
WebKit (45)
5
2002-04-24
2002-04-06
Anonymous
No

After _fields has be converted (in __init__) to a standard
dictionary, change the fields in place to accomodate an image
submit button coupled with webkit _action_ flags.

As per html
spec, image submit buttons split up the field into two fields... so,
'submit' becomes 'submit.x' and 'submit.y' with values of the x and
y coordinates where the user clicked. If there was no "click" (like
when the user presses enter or when the client is lynx, this split
still happens, but the coordinates are 0,0

NOTE: I am only doing
this for _action_[something].(x|y) fields, because that's
really only when it matters from a webkit perspective. Webkit can't
latch onto the methodname following "_action_" if the browser
appends .x and .y.

In other cases, we should assume the form
author knows what s/he is doing and leave the .x and .y there.

See
http://www.w3.org/TR/REC-html32#input for more on this
subject

- Matt Feifarek

Discussion

  • Geoff Talvola
    Geoff Talvola
    2002-04-24

    Logged In: YES
    user_id=88162

    I fixed this in a much easier way, so this patch isn't needed.
    Rather than modify the request fields, the action code simply
    looks for the presence of the fields with the ".x" and ".y"
    appended to their names. It was a one line change.

     
  • Geoff Talvola
    Geoff Talvola
    2002-04-24

    • assigned_to: nobody --> gtalvola
    • status: open --> closed-rejected