From: Edmund L. <el...@in...> - 2003-06-08 01:15:12
|
If Application.config contains a nonexistent context, Webware CVS throws the following--rather cryptic--exception, and does not actually identify what the missing context is: Traceback (most recent call last): File "WebKit/ThreadedAppServer.py", line 704, in run File "WebKit/ThreadedAppServer.py", line 71, in __init__ File "WebKit/AutoReloadingAppServer.py", line 56, in __init__ File "WebKit/AppServer.py", line 86, in __init__ File "WebKit/AppServer.py", line 209, in createApplication File "WebKit/Application.py", line 92, in __init__ File "/opt/Webware/WebKit/URLParser.py", line 112, in __init__ self.addContext(name, dir) File "/opt/Webware/WebKit/URLParser.py", line 180, in addContext mod = imp.load_module(name, *res) TypeError: load_module() argument after * must be a sequence I think it makes more sense for a warning naming the missing context to be printed to the console, and then for loading to continue. ...Edmund. |
From: Aaron H. <aaron@MetroNY.com> - 2003-06-09 16:24:08
|
A friendlier error message would be nice, but WW should not load if the Application.config is wrong. -Aaron Edmund Lian wrote: > If Application.config contains a nonexistent context, Webware CVS > throws the following--rather cryptic--exception, and does not actually > identify what the missing context is: > > Traceback (most recent call last): > File "WebKit/ThreadedAppServer.py", line 704, in run > File "WebKit/ThreadedAppServer.py", line 71, in __init__ > File "WebKit/AutoReloadingAppServer.py", line 56, in __init__ > File "WebKit/AppServer.py", line 86, in __init__ > File "WebKit/AppServer.py", line 209, in createApplication > File "WebKit/Application.py", line 92, in __init__ > File "/opt/Webware/WebKit/URLParser.py", line 112, in __init__ > self.addContext(name, dir) > File "/opt/Webware/WebKit/URLParser.py", line 180, in addContext > mod = imp.load_module(name, *res) > TypeError: load_module() argument after * must be a sequence > > > I think it makes more sense for a warning naming the missing context > to be printed to the console, and then for loading to continue. > > ...Edmund. > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Etnus, makers of TotalView, The best > thread debugger on the planet. Designed with thread debugging features > you've never dreamed of, try TotalView 6 free at www.etnus.com. > _______________________________________________ > Webware-devel mailing list > Web...@li... > https://lists.sourceforge.net/lists/listinfo/webware-devel |
From: Edmund L. <el...@in...> - 2003-06-09 16:47:25
|
Aaron Held wrote: > A friendlier error message would be nice, but WW should not load if the > Application.config is wrong. Yes, I see that other kinds of exceptions stop the load. In URLParser.py I see: 172 try: 173 importAsName = name 174 localDir, packageName = os.path.split(dir) 175 if sys.modules.has_key(importAsName): 176 mod = sys.modules[importAsName] 177 else: 178 res = imp.find_module(packageName, [localDir]) 179 mod = imp.load_module(name, *res) 180 except ImportError, e: 181 print 'Error loading context: %s: %s: dir=%s' \ 182 % (name, e, dir) 183 return It's just a minor tweak (add a check for None before 179) to get the problem fixed. Thing is though, what is a useful value to pass in for e during the exception? ...Edmund. |