Sorry Jamie everything is fine. Not sure what was up, but it seems to be ok now since I refreshed modules last night trying to figure out what on earth could be wrong. Was using 'Virtualmin Framed Theme'. My apologies for wasting time. :-(
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
... If so, make sure you are calling it
like :
icons_table(...)
and not :
print icons_table(...)
The print isn't needed, as that function already prints output...
Removing the print fixed the issue for the aforementioned themes.
Thanks for your work, it is greatly appreciated.
-Sean
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I don't see this on my test systems - which theme are you using in Webmin?
Sorry Jamie everything is fine. Not sure what was up, but it seems to be ok now since I refreshed modules last night trying to figure out what on earth could be wrong. Was using 'Virtualmin Framed Theme'. My apologies for wasting time. :-(
Ok, glad you got it worked out.
--- ./fail2ban/index.cgi 2015-02-08 22:00:00.490771252 +0000
+++ ./fail2ban/index_duplicate_icons_fix.cgi 2015-02-08 22:02:54.606774067 +$
@@ -34,7 +34,7 @@
my @icons = ( "images/filters.gif", "images/actions.gif",
"images/jails.gif", "images/config.gif",
"images/manual.gif", );
-print &icons_table(\@links, \@titles, \@icons, 5);
+&icons_table(\@links, \@titles, \@icons, 5);
# Show start / stop buttons
print &ui_hr();
Current version: Webmin 1.730 on (Debian Linux 7)
Was updated from 1.6x by apt-get install using deb http://download.webmin.com/download/repository sarge contrib
No duplicate icons on:
Gray Framed Theme
Duplicate icons on:
Old Webmin Theme
Caldera Theme
MSC.Linux Theme
StressFree theme
As per the post at http://readlist.com/lists/lists.sourceforge.net/webadmin-list/2/13459.html
... If so, make sure you are calling it
like :
icons_table(...)
and not :
print icons_table(...)
The print isn't needed, as that function already prints output...
Removing the print fixed the issue for the aforementioned themes.
Thanks for your work, it is greatly appreciated.
-Sean
You're right, there is no need to print the output of icons_table. I will fix this in the next Webmin release.