Menu

#4250 "Offer to remember login permanently" and autocomplete=off

1.630
closed-fixed
nobody
None
5
2013-06-06
2013-06-06
vilya
No

Hi,

now whether this is an actual bug or not is a good question.

However I think that the config option "Offer to remember login permanently?" (from Webmin -> Webmin Configuration -> Authentication) should also be reflected in the <form> tag:

we're currently changing ui-lib.pl as follows:

old:

$rv .= "<form class='ui_form' action='".&html_escape($script)."' ".

new:

$rv .= "<form autocomplete='off' class='ui_form' action='".&html_escape($script)."' ".

so that the browser will not ask for password storage.

I've checked latest IE, Chrome and Firefox and all three seem to respect autocomplete=off

I think that autocomplete='off' should be added to the form if "Offer to remember login permanently?" is unchecked.

Discussion

  • Jamie Cameron

    Jamie Cameron - 2013-06-06

    Good idea - I'll implement this in the next Webmin release.

     
  • Jamie Cameron

    Jamie Cameron - 2013-06-06
    • status: open --> closed-fixed
     

Log in to post a comment.