From: Manish K. <mka...@gm...> - 2007-12-17 11:49:40
|
SGksCgpJIGFtIG5ldyBiaWUgdG8gdGhpcyBncm91cCBhbmQgaGF2ZSByZWNlbnRseSBzdGFydGVk IHBsYXlpbmcgYXJvdW5kCndpdGggVU1MLiBJIHdhcyB3cml0aW5nIGEgc21hbGwgZmlsZSBzeXN0 ZW0gbW9kdWxlIGFuZCB1c2luZyBVTUwgZm9yCml0LiBJIHRyaWVkIHRvIHVzZSBnZGIgYW5kIGJy ZWFrIG9uIHJlZ2lzdGVyX2ZpbGVzeXN0ZW0sIGJ1dCB3aGVuZXZlcgppdCBnZXRzIGNhbGxlZCBp dCBjcmFzaGVzIHdpdGggdGhlIGZvbGxvd2luZyBzdGFjawoKUHJvZ3JhbSByZWNlaXZlZCBzaWdu YWwgU0lHU0VHViwgU2VnbWVudGF0aW9uIGZhdWx0LgoweDA4MDU5OWJiIGluIGNvcHlfY2h1bmtf ZnJvbV91c2VyIChmcm9tPTEzNjg5NjUzNiwgbGVuPTQwNzIsCmFyZz0weDk1ODZlNzApIGF0IGlu Y2x1ZGUvYXNtL2FyY2gvc3RyaW5nLmg6MzgKMzggICAgICBfX2FzbV9fIF9fdm9sYXRpbGVfXygK KGdkYikgYnQKIzAgIDB4MDgwNTk5YmIgaW4gY29weV9jaHVua19mcm9tX3VzZXIgKGZyb209MTM2 ODk2NTM2LCBsZW49NDA3MiwKYXJnPTB4OTU4NmU3MCkgYXQgaW5jbHVkZS9hc20vYXJjaC9zdHJp bmcuaDozOAojMSAgMHgwODA1OTgxNiBpbiBkb19vcF9vbmVfcGFnZSAoYWRkcj0xMzQ1MjA4NTYs IGxlbj00MDcyLAppc193cml0ZT0wLCBvcD0weDgwNTk5YTYgPGNvcHlfY2h1bmtfZnJvbV91c2Vy PiwgYXJnPTB4OTU4NmU3MCkKICAgIGF0IGFyY2gvdW0va2VybmVsL3NrYXMvdWFjY2Vzcy5jOjU1 CiMyICAweDA4MDU5OGFkIGluIGRvX2J1ZmZlcl9vcCAoam1wYnVmPTB4OTU4NmRlOCwgYXJnX3B0 cj0weDk1ODZlMDQpCmF0IGFyY2gvdW0va2VybmVsL3NrYXMvdWFjY2Vzcy5jOjgzCiMzICAweDA4 MDY2MTYxIGluIHNldGptcF93cmFwcGVyIChwcm9jPTB4ODA1OTgyNCA8ZG9fYnVmZmVyX29wPikg YXQKYXJjaC91bS9vcy1MaW51eC91dGlsLmM6MTAwCiM0ICAweDA4MDU5OTdiIGluIGJ1ZmZlcl9v cCAoYWRkcj0xMzQ1MjA4NTYsIGxlbj00NjEyNiwgaXNfd3JpdGU9MCwKb3A9MHg4MDU5OWE2IDxj b3B5X2NodW5rX2Zyb21fdXNlcj4sIGFyZz0weDk1ODZlNzApCiAgICBhdCBhcmNoL3VtL2tlcm5l bC9za2FzL3VhY2Nlc3MuYzoxMjUKIzUgIDB4MDgwNTlhNDQgaW4gY29weV9mcm9tX3VzZXJfc2th cyAodG89MHhhODA1MDAwLCBmcm9tPTB4ODA0YTAxOCwKbj0xNTY3OTAzODQpIGF0IGFyY2gvdW0v a2VybmVsL3NrYXMvdWFjY2Vzcy5jOjE0OQojNiAgMHgwODA4YTJlZSBpbiBsb2FkX21vZHVsZSAo dW1vZD0weDgwNGEwMTgsIGxlbj00NjEyNiwKdWFyZ3M9MHg4MDRhMDA4ICJQ77+977+9OyIpIGF0 IGFyY2gvdW0vaW5jbHVkZS91bV91YWNjZXNzLmg6NDMKIzcgIDB4MDgwOGFiZjkgaW4gc3lzX2lu aXRfbW9kdWxlICh1bW9kPTB4ODA0YTAxOCwgbGVuPTQ2MTI2LAp1YXJncz0weDgwNGEwMDggIlDv v73vv707IikgYXQga2VybmVsL21vZHVsZS5jOjE5OTAKIzggIDB4MDgwNTk0MWEgaW4gaGFuZGxl X3N5c2NhbGwgKHI9MHg4OWJhNTE0KSBhdAphcmNoL3VtL2tlcm5lbC9za2FzL3N5c2NhbGwuYzoz OAojOSAgMHgwODA2NzdmMiBpbiBoYW5kbGVfdHJhcCAocGlkPTEzMzY4LCByZWdzPTB4ODliYTUx NCwKbG9jYWxfdXNpbmdfc3lzZW11PTIpIGF0IGFyY2gvdW0vb3MtTGludXgvc2thcy9wcm9jZXNz LmM6MTczCiMxMCAweDA4MDY3YmU5IGluIHVzZXJzcGFjZSAocmVncz0weDg5YmE1MTQpIGF0CmFy Y2gvdW0vb3MtTGludXgvc2thcy9wcm9jZXNzLmM6MzMwCiMxMSAweDA4MDU5MWM1IGluIGZvcmtf aGFuZGxlciAoKSBhdCBhcmNoL3VtL2tlcm5lbC9za2FzL3Byb2Nlc3MuYzo5NgojMTIgMHgwMDAw MDAwMCBpbiA/PyAoKQoKQW55IHN1Z2dlc3Rpb25zIHdoYXQgbWlnaHQgYmUgZ29pbmcgd3Jvbmcu IE5vdGUgdGhhdCBpdCBjcmFzaGVzIG9ubHkKd2hlbiBpIHVzZSBnZGIuIE90aGVyd2lzZSBpIGFt IGFibGUgdG8gc3VjY2Vzc2Z1bGx5IGxvYWQgbXkgZmlsZXN5c3RlbQptb2R1bGUgaW4gVU1MIGFu ZCBzZWUgaW4gL3Byb2MvZmlsZXN5c3RlbXMuCgotLSAKVGhhbmtzICYgUmVnYXJkcywKKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioKTWFuaXNoIEthdGl5YXIgICgg aHR0cDovL21rYXRpeWFyLmdvb2dsZXBhZ2VzLmNvbSApCjNyZCBGbG9vciwgRmFpciBXaW5kcyBC bG9jawpFR0wgU29mdHdhcmUgUGFyawpPZmYgSW50ZXJtZWRpYXRlIFJpbmcgUm9hZApCYW5nYWxv cmUgNTYwMDcxLCBJbmRpYQoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKgo= |
From: Jeff D. <jd...@ad...> - 2007-12-17 15:52:08
|
On Mon, Dec 17, 2007 at 05:19:36PM +0530, Manish Katiyar wrote: > I tried to use gdb and break on register_filesystem, but whenever > it gets called it crashes with the following stack > > Program received signal SIGSEGV, Segmentation fault. It's not a crash. Just tell gdb handle SIGSEGV pass nostop noprint Jeff -- Work email - jdike at linux dot intel dot com |
From: Manish K. <mka...@gm...> - 2007-12-17 17:54:37
|
Hi, Thanks a lot jeff, Now i am able to boot my UML from gdb after your command. But still not able to achieve what i wanted. I wanted that when i do a "insmod mymodule.ko" from the shell prompt, since this module calls register_filesytem gdb should stop at that breakpoint. But this is not happening. The module just gets loaded successfully and silently. Is there any other way by which i can trace the register_filesystem call for my module ?? Thanks in advance On Dec 17, 2007 9:21 PM, Jeff Dike <jd...@ad...> wrote: > On Mon, Dec 17, 2007 at 05:19:36PM +0530, Manish Katiyar wrote: > > I tried to use gdb and break on register_filesystem, but whenever > > it gets called it crashes with the following stack > > > > Program received signal SIGSEGV, Segmentation fault. > > It's not a crash. Just tell gdb > handle SIGSEGV pass nostop noprint > > Jeff > > -- > Work email - jdike at linux dot intel dot com > -- Thanks & Regards, ******************************************** Manish Katiyar ( http://mkatiyar.googlepages.com ) 3rd Floor, Fair Winds Block EGL Software Park Off Intermediate Ring Road Bangalore 560071, India *********************************************** |
From: Jeff D. <jd...@ad...> - 2007-12-17 22:01:06
|
On Mon, Dec 17, 2007 at 11:24:23PM +0530, Manish Katiyar wrote: > I wanted that > when i do a "insmod mymodule.ko" from the shell prompt, since this > module calls register_filesytem gdb should stop at that breakpoint. > But this is not happening. The module just gets loaded successfully > and silently. Try applying the patch below. UML was faking gdb into believing it needs to delete breakpoints before a fork. Jeff -- Work email - jdike at linux dot intel dot com From: Stanislaw Gruszka <st...@wp...> Sometimes when UML is debugged gdb miss breakpoints. When process traced by gdb do fork, debugger remove breakpoints from child address space. There is possibility to trace more than one fork, but this not work with UML, I guess (only guess) there is a deadlock - gdb waits for UML and UML waits for gdb. When clone() is called with SIGCHLD and CLONE_VM flags, gdb see this as PTRACE_EVENT_FORK not as PTRACE_EVENT_CLONE and remove breakpoints from child and at the same time from traced process, because either have the same address space. Maybe it is possible to do fix in gdb, but I'm not sure if there is easy way to find out if traced and child processes share memory. So I do fix for UML, it simply do not call clone() with both SIGCHLD and CLONE_VM flags together. Additionally __WALL flag is used for waitpid() to assure not miss clone and normal process events. [ jdike - checkpatch fixes ] Signed-off-by: Stanislaw Gruszka <st...@wp...> Signed-off-by: Jeff Dike <jd...@li...> --- arch/um/drivers/net_user.c | 2 - arch/um/drivers/slip_user.c | 12 +-------- arch/um/drivers/slirp_user.c | 15 ++---------- arch/um/drivers/ubd_user.c | 3 -- arch/um/include/os.h | 2 - arch/um/os-Linux/aio.c | 4 +-- arch/um/os-Linux/drivers/ethertap_user.c | 10 +------- arch/um/os-Linux/drivers/tuntap_user.c | 2 - arch/um/os-Linux/helper.c | 38 ++++++++++++++++++++++--------- arch/um/os-Linux/process.c | 4 +-- arch/um/os-Linux/skas/process.c | 12 +++++---- arch/um/os-Linux/util.c | 2 - 12 files changed, 50 insertions(+), 56 deletions(-) Index: linux-2.6-git/arch/um/drivers/net_user.c =================================================================== --- linux-2.6-git.orig/arch/um/drivers/net_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/drivers/net_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -201,7 +201,7 @@ static int change_tramp(char **argv, cha close(fds[1]); if (pid > 0) - CATCH_EINTR(err = waitpid(pid, NULL, 0)); + helper_wait(pid, 0, "change_tramp"); return pid; } Index: linux-2.6-git/arch/um/drivers/slip_user.c =================================================================== --- linux-2.6-git.orig/arch/um/drivers/slip_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/drivers/slip_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -77,7 +77,7 @@ static int slip_tramp(char **argv, int f { struct slip_pre_exec_data pe_data; char *output; - int status, pid, fds[2], err, output_len; + int pid, fds[2], err, output_len; err = os_pipe(fds, 1, 0); if (err < 0) { @@ -109,15 +109,7 @@ static int slip_tramp(char **argv, int f read_output(fds[0], output, output_len); printk("%s", output); - CATCH_EINTR(err = waitpid(pid, &status, 0)); - if (err < 0) - err = errno; - else if (!WIFEXITED(status) || (WEXITSTATUS(status) != 0)) { - printk(UM_KERN_ERR "'%s' didn't exit with status 0\n", argv[0]); - err = -EINVAL; - } - else err = 0; - + err = helper_wait(pid, 0, argv[0]); close(fds[0]); out_free: Index: linux-2.6-git/arch/um/drivers/slirp_user.c =================================================================== --- linux-2.6-git.orig/arch/um/drivers/slirp_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/drivers/slirp_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -79,7 +79,7 @@ out: static void slirp_close(int fd, void *data) { struct slirp_data *pri = data; - int status,err; + int err; close(fd); close(pri->slave); @@ -98,18 +98,9 @@ static void slirp_close(int fd, void *da "(%d)\n", pri->pid, errno); } #endif - - CATCH_EINTR(err = waitpid(pri->pid, &status, WNOHANG)); - if (err < 0) { - printk(UM_KERN_ERR "slirp_close: waitpid returned %d\n", errno); + err = helper_wait(pri->pid, 1, "slirp_close"); + if (err < 0) return; - } - - if (err == 0) { - printk(UM_KERN_ERR "slirp_close: process %d has not exited\n", - pri->pid); - return; - } pri->pid = -1; } Index: linux-2.6-git/arch/um/drivers/ubd_user.c =================================================================== --- linux-2.6-git.orig/arch/um/drivers/ubd_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/drivers/ubd_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -49,8 +49,7 @@ int start_io_thread(unsigned long sp, in goto out_close; } - pid = clone(io_thread, (void *) sp, CLONE_FILES | CLONE_VM | SIGCHLD, - NULL); + pid = clone(io_thread, (void *) sp, CLONE_FILES | CLONE_VM, NULL); if(pid < 0){ err = -errno; printk("start_io_thread - clone failed : errno = %d\n", errno); Index: linux-2.6-git/arch/um/os-Linux/aio.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/aio.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/aio.c 2007-12-11 11:49:03.000000000 -0500 @@ -218,7 +218,7 @@ static int init_aio_24(void) goto out_close_pipe; err = run_helper_thread(not_aio_thread, NULL, - CLONE_FILES | CLONE_VM | SIGCHLD, &aio_stack); + CLONE_FILES | CLONE_VM, &aio_stack); if (err < 0) goto out_close_pipe; @@ -254,7 +254,7 @@ static int init_aio_26(void) } err = run_helper_thread(aio_thread, NULL, - CLONE_FILES | CLONE_VM | SIGCHLD, &aio_stack); + CLONE_FILES | CLONE_VM, &aio_stack); if (err < 0) return err; Index: linux-2.6-git/arch/um/os-Linux/drivers/ethertap_user.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/drivers/ethertap_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/drivers/ethertap_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -94,7 +94,7 @@ static int etap_tramp(char *dev, char *g int control_remote, int data_me, int data_remote) { struct etap_pre_exec_data pe_data; - int pid, status, err, n; + int pid, err, n; char version_buf[sizeof("nnnnn\0")]; char data_fd_buf[sizeof("nnnnnn\0")]; char gate_buf[sizeof("nnn.nnn.nnn.nnn\0")]; @@ -131,13 +131,7 @@ static int etap_tramp(char *dev, char *g } if (c != 1) { printk(UM_KERN_ERR "etap_tramp : uml_net failed\n"); - err = -EINVAL; - CATCH_EINTR(n = waitpid(pid, &status, 0)); - if (n < 0) - err = -errno; - else if (!WIFEXITED(status) || (WEXITSTATUS(status) != 1)) - printk(UM_KERN_ERR "uml_net didn't exit with " - "status 1\n"); + err = helper_wait(pid, 0, "uml_net"); } return err; } Index: linux-2.6-git/arch/um/os-Linux/drivers/tuntap_user.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/drivers/tuntap_user.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/drivers/tuntap_user.c 2007-12-11 11:49:03.000000000 -0500 @@ -107,7 +107,7 @@ static int tuntap_open_tramp(char *gate, "errno = %d\n", errno); return err; } - CATCH_EINTR(waitpid(pid, NULL, 0)); + helper_wait(pid, 0, "tuntap_open_tramp"); cmsg = CMSG_FIRSTHDR(&msg); if (cmsg == NULL) { Index: linux-2.6-git/arch/um/os-Linux/helper.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/helper.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/helper.c 2007-12-11 11:50:31.000000000 -0500 @@ -76,7 +76,7 @@ int run_helper(void (*pre_exec)(void *), data.fd = fds[1]; data.buf = __cant_sleep() ? kmalloc(PATH_MAX, UM_GFP_ATOMIC) : kmalloc(PATH_MAX, UM_GFP_KERNEL); - pid = clone(helper_child, (void *) sp, CLONE_VM | SIGCHLD, &data); + pid = clone(helper_child, (void *) sp, CLONE_VM, &data); if (pid < 0) { ret = -errno; printk("run_helper : clone failed, errno = %d\n", errno); @@ -101,7 +101,7 @@ int run_helper(void (*pre_exec)(void *), ret = n; kill(pid, SIGKILL); } - CATCH_EINTR(waitpid(pid, NULL, 0)); + CATCH_EINTR(waitpid(pid, NULL, __WCLONE)); } out_free2: @@ -126,7 +126,7 @@ int run_helper_thread(int (*proc)(void * return -ENOMEM; sp = stack + UM_KERN_PAGE_SIZE - sizeof(void *); - pid = clone(proc, (void *) sp, flags | SIGCHLD, arg); + pid = clone(proc, (void *) sp, flags, arg); if (pid < 0) { err = -errno; printk("run_helper_thread : clone failed, errno = %d\n", @@ -134,7 +134,7 @@ int run_helper_thread(int (*proc)(void * return err; } if (stack_out == NULL) { - CATCH_EINTR(pid = waitpid(pid, &status, 0)); + CATCH_EINTR(pid = waitpid(pid, &status, __WCLONE)); if (pid < 0) { err = -errno; printk("run_helper_thread - wait failed, errno = %d\n", @@ -150,14 +150,30 @@ int run_helper_thread(int (*proc)(void * return pid; } -int helper_wait(int pid) +int helper_wait(int pid, int nohang, char *pname) { - int ret; + int ret, status; + int wflags = __WCLONE; - CATCH_EINTR(ret = waitpid(pid, NULL, WNOHANG)); + if (nohang) + wflags |= WNOHANG; + + if (!pname) + pname = "helper_wait"; + + CATCH_EINTR(ret = waitpid(pid, &status, wflags)); if (ret < 0) { - ret = -errno; - printk("helper_wait : waitpid failed, errno = %d\n", errno); - } - return ret; + printk(UM_KERN_ERR "%s : waitpid process %d failed, " + "errno = %d\n", pname, pid, errno); + return -errno; + } else if (nohang && ret == 0) { + printk(UM_KERN_ERR "%s : process %d has not exited\n", + pname, pid); + return -ECHILD; + } else if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) { + printk(UM_KERN_ERR "%s : process %d didn't exit with " + "status 0\n", pname, pid); + return -ECHILD; + } else + return 0; } Index: linux-2.6-git/arch/um/os-Linux/process.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/process.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/process.c 2007-12-11 11:49:03.000000000 -0500 @@ -101,7 +101,7 @@ void os_kill_process(int pid, int reap_c { kill(pid, SIGKILL); if (reap_child) - CATCH_EINTR(waitpid(pid, NULL, 0)); + CATCH_EINTR(waitpid(pid, NULL, __WALL)); } /* This is here uniquely to have access to the userspace errno, i.e. the one @@ -130,7 +130,7 @@ void os_kill_ptraced_process(int pid, in ptrace(PTRACE_KILL, pid); ptrace(PTRACE_CONT, pid); if (reap_child) - CATCH_EINTR(waitpid(pid, NULL, 0)); + CATCH_EINTR(waitpid(pid, NULL, __WALL)); } /* Don't use the glibc version, which caches the result in TLS. It misses some Index: linux-2.6-git/arch/um/os-Linux/util.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/util.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/util.c 2007-12-11 11:49:03.000000000 -0500 @@ -141,7 +141,7 @@ void os_dump_core(void) * nothing reasonable to do if that fails. */ - while ((pid = waitpid(-1, NULL, WNOHANG)) > 0) + while ((pid = waitpid(-1, NULL, WNOHANG | __WALL)) > 0) os_kill_ptraced_process(pid, 0); abort(); Index: linux-2.6-git/arch/um/include/os.h =================================================================== --- linux-2.6-git.orig/arch/um/include/os.h 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/include/os.h 2007-12-11 11:49:03.000000000 -0500 @@ -214,7 +214,7 @@ extern int execvp_noalloc(char *buf, con extern int run_helper(void (*pre_exec)(void *), void *pre_data, char **argv); extern int run_helper_thread(int (*proc)(void *), void *arg, unsigned int flags, unsigned long *stack_out); -extern int helper_wait(int pid); +extern int helper_wait(int pid, int nohang, char *pname); /* tls.c */ Index: linux-2.6-git/arch/um/os-Linux/skas/process.c =================================================================== --- linux-2.6-git.orig/arch/um/os-Linux/skas/process.c 2007-12-11 11:48:08.000000000 -0500 +++ linux-2.6-git/arch/um/os-Linux/skas/process.c 2007-12-11 11:49:03.000000000 -0500 @@ -64,7 +64,7 @@ void wait_stub_done(int pid) int n, status, err; while (1) { - CATCH_EINTR(n = waitpid(pid, &status, WUNTRACED)); + CATCH_EINTR(n = waitpid(pid, &status, WUNTRACED | __WALL)); if ((n < 0) || !WIFSTOPPED(status)) goto bad_wait; @@ -153,7 +153,7 @@ static void handle_trap(int pid, struct panic("handle_trap - continuing to end of syscall " "failed, errno = %d\n", errno); - CATCH_EINTR(err = waitpid(pid, &status, WUNTRACED)); + CATCH_EINTR(err = waitpid(pid, &status, WUNTRACED | __WALL)); if ((err < 0) || !WIFSTOPPED(status) || (WSTOPSIG(status) != SIGTRAP + 0x80)) { err = ptrace_dump_regs(pid); @@ -255,16 +255,18 @@ int start_userspace(unsigned long stub_s panic("start_userspace : mmap failed, errno = %d", errno); sp = (unsigned long) stack + UM_KERN_PAGE_SIZE - sizeof(void *); - flags = CLONE_FILES | SIGCHLD; + flags = CLONE_FILES; if (proc_mm) flags |= CLONE_VM; + else + flags |= SIGCHLD; pid = clone(userspace_tramp, (void *) sp, flags, (void *) stub_stack); if (pid < 0) panic("start_userspace : clone failed, errno = %d", errno); do { - CATCH_EINTR(n = waitpid(pid, &status, WUNTRACED)); + CATCH_EINTR(n = waitpid(pid, &status, WUNTRACED | __WALL)); if (n < 0) panic("start_userspace : wait failed, errno = %d", errno); @@ -314,7 +316,7 @@ void userspace(struct uml_pt_regs *regs) "pid=%d, ptrace operation = %d, errno = %d\n", pid, op, errno); - CATCH_EINTR(err = waitpid(pid, &status, WUNTRACED)); + CATCH_EINTR(err = waitpid(pid, &status, WUNTRACED | __WALL)); if (err < 0) panic("userspace - waitpid failed, errno = %d\n", errno); |