#119 Fails to build in current debian/unstable on arm*

[Andreas Moog]

Hi there,

urjtag currently fails to build due to conflicting/duplicate identifiers:
(https://buildd.debian.org/status/fetch.php?pkg=urjtag&arch=armhf&ver=0.10%2Br2007-1.1&stamp=1406801166)

In file included from /usr/include/signal.h:352:0,
from /usr/include/arm-linux-gnueabihf/sys/wait.h:29,
from cmd_bfin.c:30:
../../include/urjtag/bfin.h:40:5: error: redeclaration of enumerator 'REG_R0'
REG_R0 = T_REG_R, REG_R1, REG_R2, REG_R3, REG_R4, REG_R5, REG_R6, REG_R7,
^
/usr/include/arm-linux-gnueabihf/sys/ucontext.h:41:3: note: previous definition >of 'REG_R0' was here
REG_R0 = 0,
^
../../include/urjtag/bfin.h:40:23: error: redeclaration of enumerator 'REG_R1'
REG_R0 = T_REG_R, REG_R1, REG_R2, REG_R3, REG_R4, REG_R5, REG_R6, REG_R7,
^
/usr/include/arm-linux-gnueabihf/sys/ucontext.h:43:3: note: previous definition >of 'REG_R1' was here
REG_R1 = 1,
^
../../include/urjtag/bfin.h:40:31: error: redeclaration of enumerator 'REG_R2'
REG_R0 = T_REG_R, REG_R1, REG_R2, REG_R3, REG_R4, REG_R5, REG_R6, REG_R7,
^
/usr/include/arm-linux-gnueabihf/sys/ucontext.h:45:3: note: previous definition >of 'REG_R2' was here
REG_R2 = 2,
^

(And similar for REG_R3-7). I have attached a patch that prefixes all REG identifiers with BFIN_REG. The build succeeds and urjtag seems to work as expected.

Let me know what you think!

Cheers,
Andreas

[Geert Stappers]

Let me know what you think!

I think that the

BFIN_  prefix

is a good thing.

[Geert Stappers]

Patch is in release 2018.09, thanks for your contribution to UrJTAG. Sorry for the tardy response.