#26 SHIFT in console

open
nobody
5
2013-03-29
2010-11-01
turkeystuffer
No

The bind to SHIFT is not deactivated while in the console.

Discussion

  • Ozkan Sezer
    Ozkan Sezer
    2010-11-01

    Thanks. Will look into.

     
  • Ozkan Sezer
    Ozkan Sezer
    2010-11-01

    Well I can't find a way to reproduce a problem with this. I can type both 'a' as well as 'A' in the console. Can you give us some information about your exact problem with SHIFT and the console?

     
  • Ozkan Sezer
    Ozkan Sezer
    2011-09-29

    This is caused by the way keys.c::Key_Event() handling the key down events. See around line 927:

    // key up events only generate commands if the game key binding is
    // a button command (leading + sign). These will occur even in console mode,
    // to keep the character from continuing an action started before a console
    // switch. Button commands include the kenum as a parameter, so multiple
    // downs can be matched with ups
    //
    if (!down)
    {
    kb = keybindings[key];
    if (kb && kb[0] == '+')
    {
    sprintf (cmd, "-%s %i\n", kb+1, key);
    Cbuf_AddText (cmd);
    }
    if (keyshift[key] != key)
    {
    kb = keybindings[keyshift[key]];
    if (kb && kb[0] == '+')
    {
    sprintf (cmd, "-%s %i\n", kb+1, key);
    Cbuf_AddText (cmd);
    }
    }
    return;
    }

    This is also the cause for the annoying barmovdn.wav sound playback when you hit the TAB key when in the console mode. I am not sure what would be the best "fix" for this. Low priority for now.