Menu

#61 Extra semicolon warning

closed
None
2016-02-07
2016-01-20
Mareq
No

Minor problem, but bit of a pain on projects treating warnings as errors:

turtle/include/turtle/detail/cleanup.hpp:31:36: warning: extra ; [-Wpedantic]
     BOOST_GLOBAL_FIXTURE( cleanup );
                                    ^

Discussion

  • Mareq

    Mareq - 2016-01-20
     
  • Mathieu Champlon

    • status: open --> accepted
    • assigned_to: Mathieu Champlon
     
  • Mathieu Champlon

    Hi,

    Oddly enough it seems prior to boost 1.59 the semicolon was not required but it looks like this was supposed to as www.boost.org/doc/libs/1_42_0/libs/test/doc/html/utf/user-guide/fixture/global.html has it.
    Then they fixed the macro in https://github.com/boostorg/test/commit/3f7216db3db2e11a768d8d0c8bb18632f106c466 which was included with boost 1.59 ...

    Anyway I suppose a proper fix in turtle would involve testing boost version.
    We already have that in several locations as boost 1.59 had a major overall of boost.test

        BOOST_GLOBAL_FIXTURE( cleanup )
    #if BOOST_VERSION >= 105900
        ;
    #endif
    
     
  • Mathieu Champlon

    Would you like to amend you pull request ? I can open another one instead if you want.

    Thanks for reporting this by the way !

    Cheers,
    MAT.

     
  • Mathieu Champlon

    FIY I just made a PR for this: https://github.com/mat007/turtle/issues/22

    MAT.

     
  • Mathieu Champlon

    • status: accepted --> pending
     
  • Mathieu Champlon

    • status: pending --> closed
     

Log in to post a comment.