Menu

#85 Algorithm ID not compliant with TSS spec

closed-fixed
5
2006-10-17
2006-10-04
norman nie
No

Hi Kent,

On p.31 of TSS spec (v1.1b), it says a key's algorithm
ID should be of TSS_ALG_*. However, currently
obj_rsakey_get_alg returns algorithmID directly, which
is set to TCPA_ALG_* (e.g. as in obj_rsakey_add()) with
no translation between the TSS_ALG_* and TCPA_ALG_*.

Cheers,

Norman

Discussion

  • Kent Yoder

    Kent Yoder - 2006-10-04
    • status: open --> open-accepted
     
  • Kent Yoder

    Kent Yoder - 2006-10-04

    Logged In: YES
    user_id=1168529

    Hi norman, I pushed a fix for this into CVS, can you try it out?

    Basically I'm taking the angle that if the algID in the
    key is TCPA_ALG_RSA, convert that to TSS_ALG_RSA, otherwise
    return whatever value is there. Then I do the opposite for
    the SetAttrib function, if its TSS_ALG_RSA, convert to
    TCPA_ALG_RSA, else just pass it through. No other values
    will make sense for an RSA key, so I think translation is
    kind of pointless in the non-RSA cases.

    Kent

     
  • Kent Yoder

    Kent Yoder - 2006-10-04
    • status: open-accepted --> open-fixed
     
  • norman nie

    norman nie - 2006-10-17

    Logged In: YES
    user_id=1535302

    Hi Kent,

    I tested out the fix. It looks good.

    Cheers,

    Norman

     
  • Kent Yoder

    Kent Yoder - 2006-10-17
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.